perf: allow assertions to be removed in production mode (#20146)

Wraps all assertions in `ngDevMode` checks so that they can be stripped away in production mode. Furthermore, changes all the places where we were using the old `isDevMode` check.

Author: crisbeto

src/BUILD.bazel

@@ -2,6 +2,7 @@ load("@npm_bazel_typescript//:index.bzl", "ts_config")
 load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
 load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
 load("//tools/dgeni:index.bzl", "dgeni_api_docs")
+load("//tools:defaults.bzl", "ts_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -43,3 +44,8 @@ dgeni_api_docs(
     },
     tags = ["docs-package"],
 )
+
+ts_library(
+    name = "dev_mode_types",
+    srcs = ["dev-mode-types.d.ts"],
+)

src/cdk-experimental/combobox/BUILD.bazel

@@ -10,6 +10,7 @@ ng_module(
     ),
     module_name = "@angular/cdk-experimental/combobox",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/a11y",
         "//src/cdk/bidi",
         "//src/cdk/collections",

src/cdk-experimental/combobox/combobox.ts

@@ -15,7 +15,7 @@ import {
   Directive,
   ElementRef,
   EventEmitter,
-  Input, isDevMode,
+  Input,
   OnDestroy,
   Optional,
   Output, ViewContainerRef
@@ -273,7 +273,8 @@ export class CdkCombobox<T = unknown> implements OnDestroy, AfterContentInit {
 
   private _coerceOpenActionProperty(input: string | OpenAction[]): OpenAction[] {
     let actions = typeof input === 'string' ? input.trim().split(/[ ,]+/) : input;
-    if (isDevMode() && actions.some(a => allowedOpenActions.indexOf(a) === -1)) {
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) &&
+      actions.some(a => allowedOpenActions.indexOf(a) === -1)) {
       throw Error(`${input} is not a support open action for CdkCombobox`);
     }
     return actions as OpenAction[];

src/cdk-experimental/dialog/BUILD.bazel

@@ -11,6 +11,7 @@ ng_module(
     assets = [":dialog-container.css"] + glob(["**/*.html"]),
     module_name = "@angular/cdk-experimental/dialog",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/a11y",
         "//src/cdk/bidi",
         "//src/cdk/keycodes",

src/cdk-experimental/dialog/dialog-container.ts

@@ -171,7 +171,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @param portal Portal to be attached as the dialog content.
    */
   attachComponentPortal<T>(portal: ComponentPortal<T>): ComponentRef<T> {
-    if (this._portalHost.hasAttached()) {
+    if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }
 
@@ -183,7 +183,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @param portal Portal to be attached as the dialog content.
    */
   attachTemplatePortal<C>(portal: TemplatePortal<C>): EmbeddedViewRef<C> {
-    if (this._portalHost.hasAttached()) {
+    if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }
 
@@ -197,7 +197,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @breaking-change 10.0.0
    */
   attachDomPortal = (portal: DomPortal) => {
-    if (this._portalHost.hasAttached()) {
+    if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }
 

src/cdk-experimental/dialog/dialog.ts

@@ -106,7 +106,7 @@ export class Dialog implements OnDestroy {
   openFromComponent<T>(component: ComponentType<T>, config?: DialogConfig): DialogRef<any> {
     config = this._applyConfigDefaults(config);
 
-    if (config.id && this.getById(config.id)) {
+    if (config.id && this.getById(config.id) && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error(`Dialog with id "${config.id}" exists already. The dialog id must be unique.`);
     }
 
@@ -125,7 +125,7 @@ export class Dialog implements OnDestroy {
   openFromTemplate<T>(template: TemplateRef<T>, config?: DialogConfig): DialogRef<any> {
     config = this._applyConfigDefaults(config);
 
-    if (config.id && this.getById(config.id)) {
+    if (config.id && this.getById(config.id) && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error(`Dialog with id "${config.id}" exists already. The dialog id must be unique.`);
     }
 

src/cdk-experimental/menu/BUILD.bazel

@@ -10,6 +10,7 @@ ng_module(
     ),
     module_name = "@angular/cdk-experimental/menu",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/a11y",
         "//src/cdk/bidi",
         "//src/cdk/coercion",

src/cdk-experimental/menu/context-menu.ts

@@ -17,7 +17,6 @@ import {
   Inject,
   Injectable,
   InjectionToken,
-  isDevMode,
 } from '@angular/core';
 import {DOCUMENT} from '@angular/common';
 import {Directionality} from '@angular/cdk/bidi';
@@ -110,9 +109,7 @@ export class CdkContextMenuTrigger implements OnDestroy {
     return this._menuPanel;
   }
   set menuPanel(panel: CdkMenuPanel) {
-    // If the provided panel already has a stack, that means it already has a trigger configured
-    // TODO refactor once https://github.com/angular/components/pull/20146 lands
-    if (isDevMode() && panel._menuStack) {
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) && panel._menuStack) {
       throwExistingMenuStackError();
     }
     this._menuPanel = panel;

src/cdk-experimental/menu/menu-item-trigger.ts

@@ -16,7 +16,6 @@ import {
   Inject,
   OnDestroy,
   Optional,
-  isDevMode,
 } from '@angular/core';
 import {Directionality} from '@angular/cdk/bidi';
 import {TemplatePortal} from '@angular/cdk/portal';
@@ -64,8 +63,7 @@ export class CdkMenuItemTrigger implements OnDestroy {
     // If the provided panel already has a stack, that means it already has a trigger configured.
     // Note however that there are some edge cases where two triggers **may** share the same menu,
     // e.g. two triggers in two separate menus.
-    // TODO refactor once https://github.com/angular/components/pull/20146 lands
-    if (isDevMode() && panel?._menuStack) {
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) && panel?._menuStack) {
       throwExistingMenuStackError();
     }
 

src/cdk-experimental/scrolling/BUILD.bazel

@@ -11,6 +11,7 @@ ng_module(
     ),
     module_name = "@angular/cdk-experimental/scrolling",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/coercion",
         "//src/cdk/collections",
         "//src/cdk/scrolling",