refactor(multiple): enable noImplicitOverride typescript option (#22830)

* refactor(multiple): enable `noImplicitOverride` typescript option

Enables the TypeScript `noImplicitOverride` option and adds
the `override` keyword where needed.

* build: add yarn script alias for tsc

Adds a `yarn run` alias for the `tsc` binary. Since we have
multiple versions of TypeScript installed, Yarn can pick
another version (e.g. from `typescript-4.2`) for linking
the `tsc` binary. This is unexpected because `yarn tsc` should
resolve to the TypeScript version that is not installed through
a Yarn alias. Changing the order in the Yarn lock file does not
help, and it seems expected in the context of Yarn which does not
know which package (regardless of alias or not) to prefer.

Author: devversion

package.json

@@ -50,6 +50,7 @@
     "check-mdc-tests": "ts-node --project scripts/tsconfig.json scripts/check-mdc-tests.ts",
     "check-mdc-exports": "ts-node --project scripts/tsconfig.json scripts/check-mdc-exports.ts",
     "check-tools": "yarn tsc --project tools/tsconfig-ci.json",
+    "tsc": "node ./node_modules/typescript/bin/tsc",
     "prepare": "husky install"
   },
   "version": "12.1.0",

src/bazel-tsconfig-build.json

@@ -14,6 +14,7 @@
     "strictNullChecks": true,
     "noImplicitReturns": true,
     "strictFunctionTypes": true,
+    "noImplicitOverride": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitAny": true,
     "noImplicitThis": true,

src/cdk-experimental/dialog/dialog-container.ts

@@ -196,7 +196,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @deprecated To be turned into a method.
    * @breaking-change 10.0.0
    */
-  attachDomPortal = (portal: DomPortal) => {
+  override attachDomPortal = (portal: DomPortal) => {
     if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }

src/cdk-experimental/menu/menu-bar.ts

@@ -86,7 +86,7 @@ export class CdkMenuBar extends CdkMenuGroup implements Menu, AfterContentInit,
     super();
   }
 
-  ngAfterContentInit() {
+  override ngAfterContentInit() {
     super.ngAfterContentInit();
 
     this._setKeyManager();
@@ -287,7 +287,7 @@ export class CdkMenuBar extends CdkMenuGroup implements Menu, AfterContentInit,
     return !!this._openItem;
   }
 
-  ngOnDestroy() {
+  override ngOnDestroy() {
     super.ngOnDestroy();
 
     this._destroyed.next();

src/cdk-experimental/menu/menu-item-checkbox.ts

@@ -31,7 +31,7 @@ import {CdkMenuItem} from './menu-item';
 })
 export class CdkMenuItemCheckbox extends CdkMenuItemSelectable {
   /** Toggle the checked state of the checkbox. */
-  trigger() {
+  override trigger() {
     super.trigger();
 
     if (!this.disabled) {

src/cdk-experimental/menu/menu-item-radio.ts

@@ -63,15 +63,15 @@ export class CdkMenuItemRadio extends CdkMenuItemSelectable implements OnDestroy
   }
 
   /** Toggles the checked state of the radio-button. */
-  trigger() {
+  override trigger() {
     super.trigger();
 
     if (!this.disabled) {
       this._selectionDispatcher.notify(this.id, this.name);
     }
   }
 
-  ngOnDestroy() {
+  override ngOnDestroy() {
     super.ngOnDestroy();
     this._removeDispatcherListener();
   }

src/cdk-experimental/menu/menu-item-selectable.ts

@@ -40,7 +40,7 @@ export abstract class CdkMenuItemSelectable extends CdkMenuItem {
   @Input() id: string = `cdk-selectable-item-${nextId++}`;
 
   /** If the element is not disabled emit the click event */
-  trigger() {
+  override trigger() {
     if (!this.disabled) {
       this.toggled.next(this);
     }

src/cdk-experimental/menu/menu-stack.ts

@@ -130,5 +130,5 @@ export class MenuStack {
 /** NoopMenuStack is a placeholder MenuStack used for inline menus. */
 export class NoopMenuStack extends MenuStack {
   /** Noop push - does not add elements to the MenuStack. */
-  push(_: MenuStackItem) {}
+  override push(_: MenuStackItem) {}
 }

src/cdk-experimental/menu/menu.ts

@@ -124,7 +124,7 @@ export class CdkMenu extends CdkMenuGroup implements Menu, AfterContentInit, OnI
     this._registerWithParentPanel();
   }
 
-  ngAfterContentInit() {
+  override ngAfterContentInit() {
     super.ngAfterContentInit();
 
     this._completeChangeEmitter();
@@ -348,7 +348,7 @@ export class CdkMenu extends CdkMenuGroup implements Menu, AfterContentInit, OnI
     return this._menuStack instanceof NoopMenuStack;
   }
 
-  ngOnDestroy() {
+  override ngOnDestroy() {
     this._emitClosedEvent();
     this._pointerTracker?.destroy();
   }

src/cdk-experimental/popover-edit/table-directives.ts

@@ -362,15 +362,15 @@ export class CdkPopoverEdit<C> implements AfterViewInit, OnDestroy {
   inputs: POPOVER_EDIT_INPUTS,
 })
 export class CdkPopoverEditTabOut<C> extends CdkPopoverEdit<C> {
-  protected focusTrap?: FocusEscapeNotifier;
+  protected override focusTrap?: FocusEscapeNotifier;
 
   constructor(
       elementRef: ElementRef, viewContainerRef: ViewContainerRef, services: EditServices,
       protected readonly focusEscapeNotifierFactory: FocusEscapeNotifierFactory) {
     super(services, elementRef, viewContainerRef);
   }
 
-  protected initFocusTrap(): void {
+  protected override initFocusTrap(): void {
     this.focusTrap = this.focusEscapeNotifierFactory.create(this.overlayRef!.overlayElement);
 
     this.focusTrap.escapes().pipe(takeUntil(this.destroyed)).subscribe(direction => {