refactor(multiple): ensure compatibility with TypeScript 4.3

Refactors code that fails with TypeScript 4.3. These changes are limited
to the update migration as everything else remained compatible.

This commit adds an integration test to ensure that the built NPM
packages work with TypeScript 4.3.

(cherry picked from commit 25924fa)

Author: devversion

integration/ts-compat/BUILD.bazel

@@ -13,6 +13,7 @@ write_file(
 # List of TypeScript packages that we want to run the compatibility test against.
 # The list contains NPM module names that resolve to the desired TypeScript version.
 typescript_version_packages = [
+    "typescript-4.3",
     "typescript",
 ]
 

package.json

@@ -224,6 +224,7 @@
     "tslint": "^6.1.3",
     "tsutils": "^3.17.1",
     "typescript": "~4.2.3",
+    "typescript-4.3": "npm:typescript@4.3.2",
     "vrsource-tslint-rules": "6.0.0",
     "yaml": "^1.10.0"
   },

scripts/caretaking/firebase-functions/package.json

@@ -11,7 +11,7 @@
     "firebase-functions": "^3.11.0"
   },
   "devDependencies": {
-    "typescript": "^4.0.2",
+    "typescript": "^4.3.2",
     "firebase-tools": "^8.6.0"
   },
   "private": true

scripts/caretaking/firebase-functions/yarn.lock

@@ -3794,10 +3794,10 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^4.0.2:
-  version "4.0.3"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.0.3.tgz#153bbd468ef07725c1df9c77e8b453f8d36abba5"
-  integrity sha512-tEu6DGxGgRJPb/mVPIZ48e69xCn2yRmCgYmDugAVwmJ6o+0u1RI18eO7E7WBTLYLaEVVOhwQmcdhQHweux/WPg==
+typescript@^4.3.2:
+  version "4.3.2"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.3.2.tgz#399ab18aac45802d6f2498de5054fcbbe716a805"
+  integrity sha512-zZ4hShnmnoVnAHpVHWpTcxdv7dWP60S2FsydQLV8V5PbS3FifjWFFRiHSWpDJahly88PRyV5teTSLoq4eG7mKw==
 
 unique-string@^1.0.0:
   version "1.0.0"

src/cdk/schematics/ng-update/migrations/constructor-signature.ts

@@ -94,10 +94,11 @@ export class ConstructorSignatureMigration extends Migration<UpgradeData> {
           signature => getParameterTypesFromSignature(signature, this.typeChecker));
 
       const expressionName = isNewExpression ? `new ${className}` : 'super';
-      const signatures =
-          classSignatures.map(signature => signature.map(t => this.typeChecker.typeToString(t)))
-              .map(signature => `${expressionName}(${signature.join(', ')})`)
-              .join(' or ');
+      const signatures = classSignatures
+          .map(signature =>
+              signature.map(t => t === null ? 'any' : this.typeChecker.typeToString(t)))
+          .map(signature => `${expressionName}(${signature.join(', ')})`)
+          .join(' or ');
 
       this.createFailureAtNode(
           node,
@@ -111,9 +112,9 @@ export class ConstructorSignatureMigration extends Migration<UpgradeData> {
 
 /** Resolves the type for each parameter in the specified signature. */
 function getParameterTypesFromSignature(
-    signature: ts.Signature, typeChecker: ts.TypeChecker): ts.Type[] {
+    signature: ts.Signature, typeChecker: ts.TypeChecker): (ts.Type|null)[] {
   return signature.getParameters().map(
-      param => typeChecker.getTypeAtLocation(param.declarations[0]));
+      param => param.declarations ? typeChecker.getTypeAtLocation(param.declarations[0]) : null);
 }
 
 /**

src/material/schematics/ng-update/migrations/hammer-gestures-v9/hammer-gestures-migration.ts

@@ -648,7 +648,7 @@ export class HammerGesturesMigration extends DevkitMigration<null> {
     const mainFilePath = getProjectMainFile(project);
     const rootModuleSymbol = this._getRootModuleSymbol(mainFilePath);
 
-    if (rootModuleSymbol === null) {
+    if (rootModuleSymbol === null || rootModuleSymbol.valueDeclaration === undefined) {
       this.failures.push({
         filePath: mainFilePath,
         message: `Could not setup Hammer gestures in module. Please ` +
@@ -726,7 +726,7 @@ export class HammerGesturesMigration extends DevkitMigration<null> {
     const mainFilePath = getProjectMainFile(project);
     const rootModuleSymbol = this._getRootModuleSymbol(mainFilePath);
 
-    if (rootModuleSymbol === null) {
+    if (rootModuleSymbol === null || rootModuleSymbol.valueDeclaration === undefined) {
       this.failures.push({
         filePath: mainFilePath,
         message: `Could not setup HammerModule. Please manually set up the "HammerModule" ` +

src/material/schematics/ng-update/migrations/package-imports-v8/secondary-entry-points-migration.ts

@@ -169,7 +169,7 @@ function getDeclarationSymbolOfNode(node: ts.Node, checker: ts.TypeChecker): ts.
 
 
 /** Tries to resolve the name of the Material module that a node is imported from. */
-function resolveModuleName(node: ts.Identifier, typeChecker: ts.TypeChecker) {
+function resolveModuleName(node: ts.Identifier, typeChecker: ts.TypeChecker): string|null {
   // Get the symbol for the named binding element. Note that we cannot determine the
   // value declaration based on the type of the element as types are not necessarily
   // specific to a given secondary entry-point (e.g. exports with the type of "string")
@@ -186,7 +186,12 @@ function resolveModuleName(node: ts.Identifier, typeChecker: ts.TypeChecker) {
   // The filename for the source file of the node that contains the
   // first declaration of the symbol. All symbol declarations must be
   // part of a defining node, so parent can be asserted to be defined.
-  const resolvedNode = symbol.valueDeclaration || symbol.declarations[0];
+  const resolvedNode = symbol.valueDeclaration || symbol.declarations?.[0];
+
+  if (resolvedNode === undefined) {
+    return null;
+  }
+
   const sourceFile = resolvedNode.getSourceFile().fileName;
 
   // File the module the symbol belongs to from a regex match of the

tools/tslint-rules/coercionTypesRule.ts

@@ -128,7 +128,7 @@ class Walker extends Lint.RuleWalker {
       }
 
       const symbol = this._typeChecker.getTypeAtLocation(baseType).getSymbol();
-      currentClass = symbol && ts.isClassDeclaration(symbol.valueDeclaration) ?
+      currentClass = symbol?.valueDeclaration && ts.isClassDeclaration(symbol.valueDeclaration) ?
           symbol.valueDeclaration : null;
 
       if (currentClass) {

tools/tslint-rules/noUndecoratedBaseClassDiRule.ts

@@ -72,7 +72,8 @@ class Walker extends Lint.RuleWalker {
         return null;
       }
       const symbol = this._typeChecker.getTypeAtLocation(baseTypes[0]).getSymbol();
-      if (!symbol || !ts.isClassDeclaration(symbol.valueDeclaration)) {
+      if (symbol?.valueDeclaration === undefined ||
+          !ts.isClassDeclaration(symbol.valueDeclaration)) {
         return null;
       }
       if (this.hasExplicitConstructor(symbol.valueDeclaration)) {

yarn.lock

@@ -13107,6 +13107,11 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
+"typescript-4.3@npm:typescript@4.3.2":
+  version "4.3.2"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.3.2.tgz#399ab18aac45802d6f2498de5054fcbbe716a805"
+  integrity sha512-zZ4hShnmnoVnAHpVHWpTcxdv7dWP60S2FsydQLV8V5PbS3FifjWFFRiHSWpDJahly88PRyV5teTSLoq4eG7mKw==
+
 typescript@4.2.3, typescript@^3.2.2, typescript@~4.2.3:
   version "4.2.3"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.2.3.tgz#39062d8019912d43726298f09493d598048c1ce3"