refactor: expand private getter restrictions to underscored members (#20083)

We have a lint rule that doesn't allow private getters, because they increase the generated ES5 code without much benefit for a private API. These changes expand the restrictions to any public members that are prefixed with an underscore since we don't consider them part of the public API surface.

(cherry picked from commit 3dce841)

Author: crisbeto

src/cdk-experimental/dialog/dialog-container.ts

@@ -87,7 +87,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
   // @HostBinding is used in the class as it is expected to be extended. Since @Component decorator
   // metadata is not inherited by child classes, instead the host binding data is defined in a way
   // that can be inherited.
-  // tslint:disable:no-host-decorator-in-concrete
+  // tslint:disable:no-host-decorator-in-concrete no-private-getters
   @HostBinding('attr.aria-label') get _ariaLabel() { return this._config.ariaLabel || null; }
 
   @HostBinding('attr.aria-describedby')
@@ -98,7 +98,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
   @HostBinding('attr.aria-modal') _ariaModal: boolean = true;
 
   @HostBinding('attr.tabindex') get _tabindex() { return -1; }
-  // tslint:disable:no-host-decorator-in-concrete
+  // tslint:disable:no-host-decorator-in-concrete no-private-getters
 
   /** The portal host inside of this container into which the dialog content will be loaded. */
   @ViewChild(CdkPortalOutlet, {static: true}) _portalHost: CdkPortalOutlet;

src/cdk-experimental/dialog/dialog.ts

@@ -50,14 +50,14 @@ export class Dialog implements OnDestroy {
   private _scrollStrategy: () => ScrollStrategy;
 
   /** Stream that emits when all dialogs are closed. */
-  get _afterAllClosed(): Observable<void> {
+  _getAfterAllClosed(): Observable<void> {
     return this._parentDialog ? this._parentDialog.afterAllClosed : this._afterAllClosedBase;
   }
   _afterAllClosedBase = new Subject<void>();
 
   // TODO(jelbourn): tighten the type on the right-hand side of this expression.
   afterAllClosed: Observable<void> = defer(() => this.openDialogs.length ?
-      this._afterAllClosed : this._afterAllClosed.pipe(startWith(undefined)));
+      this._getAfterAllClosed() : this._getAfterAllClosed().pipe(startWith(undefined)));
 
   /** Stream that emits when a dialog is opened. */
   get afterOpened(): Subject<DialogRef<any>> {

src/cdk/overlay/position/connected-position-strategy.ts

@@ -45,11 +45,6 @@ export class ConnectedPositionStrategy implements PositionStrategy {
 
   private _direction: Direction | null;
 
-  /** Whether the we're dealing with an RTL context */
-  get _isRtl() {
-    return this._overlayRef.getDirection() === 'rtl';
-  }
-
   /** Ordered list of preferred positions, from most to least desirable. */
   _preferredPositions: ConnectionPositionPair[] = [];
 

src/material-experimental/mdc-chips/chip-grid.spec.ts

@@ -533,12 +533,12 @@ describe('MDC-based MatChipGrid', () => {
         secondChip.focus();
         fixture.detectChanges();
 
-        expect(chipGridInstance._chips.toArray().findIndex(chip => chip._hasFocus)).toBe(1);
+        expect(chipGridInstance._chips.toArray().findIndex(chip => chip._hasFocus())).toBe(1);
 
         dispatchKeyboardEvent(secondChip, 'keydown', DELETE);
         fixture.detectChanges();
 
-        expect(chipGridInstance._chips.toArray().findIndex(chip => chip._hasFocus)).toBe(1);
+        expect(chipGridInstance._chips.toArray().findIndex(chip => chip._hasFocus())).toBe(1);
       });
 
       describe('when the input has focus', () => {

src/material-experimental/mdc-chips/chip-option.ts

@@ -183,7 +183,7 @@ export class MatChipOption extends MatChip implements AfterContentInit {
       return;
     }
 
-    if (!this._hasFocus) {
+    if (!this._hasFocus()) {
       this._elementRef.nativeElement.focus();
       this._onFocus.next({chip: this});
     }

src/material-experimental/mdc-chips/chip-row.ts

@@ -150,7 +150,7 @@ export class MatChipRow extends MatChip implements AfterContentInit, AfterViewIn
     this._hasFocusInternal = false;
     // Wait to see if focus moves to the other gridcell
     setTimeout(() => {
-      if (this._hasFocus) {
+      if (this._hasFocus()) {
         return;
       }
       this._onBlur.next({chip: this});

src/material-experimental/mdc-chips/chip-set.ts

@@ -193,7 +193,7 @@ export class MatChipSet extends _MatChipSetMixinBase implements AfterContentInit
 
   /** Checks whether any of the chips is focused. */
   protected _hasFocusedChip() {
-    return this._chips && this._chips.some(chip => chip._hasFocus);
+    return this._chips && this._chips.some(chip => chip._hasFocus());
   }
 
   /** Syncs the chip-set's state with the individual chips. */
@@ -251,7 +251,7 @@ export class MatChipSet extends _MatChipSetMixinBase implements AfterContentInit
       // In case the chip that will be removed is currently focused, we temporarily store
       // the index in order to be able to determine an appropriate sibling chip that will
       // receive focus.
-      if (this._isValidIndex(chipIndex) && chip._hasFocus) {
+      if (this._isValidIndex(chipIndex) && chip._hasFocus()) {
         this._lastDestroyedChipIndex = chipIndex;
       }
     });

src/material-experimental/mdc-chips/chip.ts

@@ -158,7 +158,7 @@ export class MatChip extends _MatChipMixinBase implements AfterContentInit, Afte
     this._chipFoundation.handleTransitionEnd(event);
   }
 
-  get _hasFocus() {
+  _hasFocus() {
     return this._hasFocusInternal;
   }
 

src/material/datepicker/datepicker-base.ts

@@ -341,16 +341,16 @@ export abstract class MatDatepickerBase<C extends MatDatepickerControl<D>, S,
   id: string = `mat-datepicker-${datepickerUid++}`;
 
   /** The minimum selectable date. */
-  get _minDate(): D | null {
+  _getMinDate(): D | null {
     return this._datepickerInput && this._datepickerInput.min;
   }
 
   /** The maximum selectable date. */
-  get _maxDate(): D | null {
+  _getMaxDate(): D | null {
     return this._datepickerInput && this._datepickerInput.max;
   }
 
-  get _dateFilter(): DateFilterFn<D> {
+  _getDateFilter(): DateFilterFn<D> {
     return this._datepickerInput && this._datepickerInput.dateFilter;
   }
 

src/material/datepicker/datepicker-content.html

@@ -3,9 +3,9 @@
     [ngClass]="datepicker.panelClass"
     [startAt]="datepicker.startAt"
     [startView]="datepicker.startView"
-    [minDate]="datepicker._minDate"
-    [maxDate]="datepicker._maxDate"
-    [dateFilter]="datepicker._dateFilter"
+    [minDate]="datepicker._getMinDate()"
+    [maxDate]="datepicker._getMaxDate()"
+    [dateFilter]="datepicker._getDateFilter()"
     [headerComponent]="datepicker.calendarHeaderComponent"
     [selected]="_getSelected()"
     [dateClass]="datepicker.dateClass"