refactor(cdk/a11y): switch to input transforms

Switches inputs in cdk/a11y to use transforms instead of getters/setters.

Author: crisbeto

src/cdk/overlay/overlay-directives.ts

@@ -7,7 +7,6 @@
  */
 
 import {Direction, Directionality} from '@angular/cdk/bidi';
-import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {ESCAPE, hasModifierKey} from '@angular/cdk/keycodes';
 import {TemplatePortal} from '@angular/cdk/portal';
 import {
@@ -100,11 +99,6 @@ export class CdkOverlayOrigin {
 export class CdkConnectedOverlay implements OnDestroy, OnChanges {
   private _overlayRef: OverlayRef;
   private _templatePortal: TemplatePortal;
-  private _hasBackdrop = false;
-  private _lockPosition = false;
-  private _growAfterOpen = false;
-  private _flexibleDimensions = false;
-  private _push = false;
   private _backdropSubscription = Subscription.EMPTY;
   private _attachSubscription = Subscription.EMPTY;
   private _detachSubscription = Subscription.EMPTY;
@@ -188,49 +182,23 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
   @Input('cdkConnectedOverlayTransformOriginOn') transformOriginSelector: string;
 
   /** Whether or not the overlay should attach a backdrop. */
-  @Input('cdkConnectedOverlayHasBackdrop')
-  get hasBackdrop(): boolean {
-    return this._hasBackdrop;
-  }
-  set hasBackdrop(value: BooleanInput) {
-    this._hasBackdrop = coerceBooleanProperty(value);
-  }
+  @Input({alias: 'cdkConnectedOverlayHasBackdrop', transform: booleanAttribute})
+  hasBackdrop: boolean = false;
 
   /** Whether or not the overlay should be locked when scrolling. */
-  @Input('cdkConnectedOverlayLockPosition')
-  get lockPosition(): boolean {
-    return this._lockPosition;
-  }
-  set lockPosition(value: BooleanInput) {
-    this._lockPosition = coerceBooleanProperty(value);
-  }
+  @Input({alias: 'cdkConnectedOverlayLockPosition', transform: booleanAttribute})
+  lockPosition: boolean = false;
 
   /** Whether the overlay's width and height can be constrained to fit within the viewport. */
-  @Input('cdkConnectedOverlayFlexibleDimensions')
-  get flexibleDimensions(): boolean {
-    return this._flexibleDimensions;
-  }
-  set flexibleDimensions(value: BooleanInput) {
-    this._flexibleDimensions = coerceBooleanProperty(value);
-  }
+  @Input({alias: 'cdkConnectedOverlayFlexibleDimensions', transform: booleanAttribute})
+  flexibleDimensions: boolean = false;
 
   /** Whether the overlay can grow after the initial open when flexible positioning is turned on. */
-  @Input('cdkConnectedOverlayGrowAfterOpen')
-  get growAfterOpen(): boolean {
-    return this._growAfterOpen;
-  }
-  set growAfterOpen(value: BooleanInput) {
-    this._growAfterOpen = coerceBooleanProperty(value);
-  }
+  @Input({alias: 'cdkConnectedOverlayGrowAfterOpen', transform: booleanAttribute})
+  growAfterOpen: boolean = false;
 
   /** Whether the overlay can be pushed on-screen if none of the provided positions fit. */
-  @Input('cdkConnectedOverlayPush')
-  get push(): boolean {
-    return this._push;
-  }
-  set push(value: BooleanInput) {
-    this._push = coerceBooleanProperty(value);
-  }
+  @Input({alias: 'cdkConnectedOverlayPush', transform: booleanAttribute}) push: boolean = false;
 
   /** Whether the overlay should be disposed of when the user goes backwards/forwards in history. */
   @Input({alias: 'cdkConnectedOverlayDisposeOnNavigation', transform: booleanAttribute})

tools/public_api_guard/cdk/overlay.md

@@ -4,7 +4,6 @@
 
 ```ts
 
-import { BooleanInput } from '@angular/cdk/coercion';
 import { CdkScrollable } from '@angular/cdk/scrolling';
 import { ComponentFactoryResolver } from '@angular/core';
 import { ComponentPortal } from '@angular/cdk/portal';
@@ -55,20 +54,26 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
     disableClose: boolean;
     get disposeOnNavigation(): boolean;
     set disposeOnNavigation(value: boolean);
-    get flexibleDimensions(): boolean;
-    set flexibleDimensions(value: BooleanInput);
-    get growAfterOpen(): boolean;
-    set growAfterOpen(value: BooleanInput);
-    get hasBackdrop(): boolean;
-    set hasBackdrop(value: BooleanInput);
+    flexibleDimensions: boolean;
+    growAfterOpen: boolean;
+    hasBackdrop: boolean;
     height: number | string;
-    get lockPosition(): boolean;
-    set lockPosition(value: BooleanInput);
+    lockPosition: boolean;
     minHeight: number | string;
     minWidth: number | string;
     // (undocumented)
     static ngAcceptInputType_disposeOnNavigation: unknown;
     // (undocumented)
+    static ngAcceptInputType_flexibleDimensions: unknown;
+    // (undocumented)
+    static ngAcceptInputType_growAfterOpen: unknown;
+    // (undocumented)
+    static ngAcceptInputType_hasBackdrop: unknown;
+    // (undocumented)
+    static ngAcceptInputType_lockPosition: unknown;
+    // (undocumented)
+    static ngAcceptInputType_push: unknown;
+    // (undocumented)
     ngOnChanges(changes: SimpleChanges): void;
     // (undocumented)
     ngOnDestroy(): void;
@@ -85,8 +90,7 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
     readonly positionChange: EventEmitter<ConnectedOverlayPositionChange>;
     positions: ConnectedPosition[];
     positionStrategy: FlexibleConnectedPositionStrategy;
-    get push(): boolean;
-    set push(value: BooleanInput);
+    push: boolean;
     scrollStrategy: ScrollStrategy;
     transformOriginSelector: string;
     viewportMargin: number;