ci: report size-test failures to separate slack channel (#20033)

No longer reports size-test failures to the #components-ci-failures
Slack channel. This channel should only receive messages for actual
job failures. The size tests do not cause CI to turn red, so they
should be handled in a separate channel.

Author: devversion

.circleci/config.yml

@@ -143,7 +143,7 @@ var_21: &slack_notify_on_failure
   run:
     name: "Notifying team about job failure"
     when: on_fail
-    command: ./scripts/circleci/notify-slack-job-failure.sh
+    command: node ./scripts/circleci/notify-slack-job-failure.js
 
 # -----------------------------
 # Container version of CircleCI
@@ -582,7 +582,8 @@ jobs:
       - run:
           name: Running size integration tests (failures are reported in Slack only).
           command: |
-            yarn integration-tests:size-test || ./scripts/circleci/notify-slack-job-failure.sh
+            # If the size integration tests fail, report the failure to a dedicated #components-ci-size-tracking Slack channel.
+            yarn integration-tests:size-test || node ./scripts/circleci/notify-slack-job-failure.js components-ci-size-tracking
       - run: yarn integration-tests:view-engine
       - *slack_notify_on_failure
 

scripts/circleci/notify-slack-job-failure.js

@@ -0,0 +1,35 @@
+#!/usr/bin/env node
+
+/**
+ * Script that notifies Slack about the currently failing job. This script
+ * will be a noop when running for forked builds (i.e. PRs).
+ */
+
+if (process.env.CIRCLE_PR_NUMBER) {
+  console.info('Skipping notifications for pull requests.');
+  process.exit(0);
+}
+
+const {echo, set} = require('shelljs');
+const {
+  CIRCLE_JOB: jobName,
+  CIRCLE_BRANCH: branchName,
+  CIRCLE_BUILD_URL: jobUrl,
+  SLACK_COMPONENTS_CI_FAILURES_WEBHOOK_URL: webhookUrl,
+} = process.env;
+
+const text = `\`${jobName}\` failed in branch: ${branchName}: ${jobUrl}`;
+const payload = {text};
+const [channelName] = process.argv.slice(2);
+
+set('-e');
+
+// If an explicit channel has been specified, override the default
+// webhook channel to the specified one.
+if (channelName !== undefined) {
+  payload.channel = channelName;
+}
+
+echo(JSON.stringify(payload, null, 2))
+  .exec(`curl -d@- -H "Content-Type: application/json" ${webhookUrl}`);
+console.info('Notified Slack about job failure.');