Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

Commit b3bf1b9

Browse files
committed
fix(leafletData unresolveMap): argument naming renamed scopeId to mapId
1 parent ffcfa2f commit b3bf1b9

File tree

7 files changed

+27
-27
lines changed

7 files changed

+27
-27
lines changed

.jshintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"eqeqeq": true,
88
"immed": true,
99
"indent": 4,
10-
"latedef": true,
10+
"latedef": false,
1111
"newcap": true,
1212
"noarg": true,
1313
"regexp": true,

dist/ui-leaflet.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* ui-leaflet 1.0.0 2015-11-03
2+
* ui-leaflet 1.0.0 2016-06-07
33
* ui-leaflet - An AngularJS directive to easily interact with Leaflet maps
44
* git: https://github.com/angular-ui/ui-leaflet
55
*/
@@ -456,8 +456,8 @@ angular.module('ui-leaflet').service('leafletData', ["leafletLogger", "$q", "lea
456456
_private[itemName] = {};
457457
});
458458

459-
this.unresolveMap = function (scopeId) {
460-
var id = leafletHelpers.obtainEffectiveMapId(_private.map, scopeId);
459+
this.unresolveMap = function (mapId) {
460+
var id = leafletHelpers.obtainEffectiveMapId(_private.map, mapId);
461461
_privateItems.forEach(function (itemName) {
462462
_private[itemName][id] = undefined;
463463
});
@@ -466,14 +466,14 @@ angular.module('ui-leaflet').service('leafletData', ["leafletLogger", "$q", "lea
466466
//int repetitive stuff (get and sets)
467467
_privateItems.forEach(function (itemName) {
468468
var name = upperFirst(itemName);
469-
self['set' + name] = function (lObject, scopeId) {
470-
var defer = getUnresolvedDefer(_private[itemName], scopeId);
469+
self['set' + name] = function (lObject, mapId) {
470+
var defer = getUnresolvedDefer(_private[itemName], mapId);
471471
defer.resolve(lObject);
472-
setResolvedDefer(_private[itemName], scopeId);
472+
setResolvedDefer(_private[itemName], mapId);
473473
};
474474

475-
self['get' + name] = function (scopeId) {
476-
var defer = getDefer(_private[itemName], scopeId);
475+
self['get' + name] = function (mapId) {
476+
var defer = getDefer(_private[itemName], mapId);
477477
return defer.promise;
478478
};
479479
});

dist/ui-leaflet.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ui-leaflet.min.no-header.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ui-leaflet_dev_mapped.js

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ui-leaflet_dev_mapped.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/services/leafletData.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ angular.module('ui-leaflet').service('leafletData', function (leafletLogger, $q,
2727
_private[itemName] = {};
2828
});
2929

30-
this.unresolveMap = function (scopeId) {
31-
var id = leafletHelpers.obtainEffectiveMapId(_private.map, scopeId);
30+
this.unresolveMap = function (mapId) {
31+
var id = leafletHelpers.obtainEffectiveMapId(_private.map, mapId);
3232
_privateItems.forEach(function (itemName) {
3333
_private[itemName][id] = undefined;
3434
});
@@ -37,14 +37,14 @@ angular.module('ui-leaflet').service('leafletData', function (leafletLogger, $q,
3737
//int repetitive stuff (get and sets)
3838
_privateItems.forEach(function (itemName) {
3939
var name = upperFirst(itemName);
40-
self['set' + name] = function (lObject, scopeId) {
41-
var defer = getUnresolvedDefer(_private[itemName], scopeId);
40+
self['set' + name] = function (lObject, mapId) {
41+
var defer = getUnresolvedDefer(_private[itemName], mapId);
4242
defer.resolve(lObject);
43-
setResolvedDefer(_private[itemName], scopeId);
43+
setResolvedDefer(_private[itemName], mapId);
4444
};
4545

46-
self['get' + name] = function (scopeId) {
47-
var defer = getDefer(_private[itemName], scopeId);
46+
self['get' + name] = function (mapId) {
47+
var defer = getDefer(_private[itemName], mapId);
4848
return defer.promise;
4949
};
5050
});

0 commit comments

Comments
 (0)