Merge pull request #55 from Tinder/maxwelle/optimize_rdeps

tinder-maxwellelliott · web-flow · commit e96c5792ee8a · 2021-03-04T09:17:20.000-08:00
Attempt to optimize rdeps queries
diff --git a/src/main/java/com/bazel_diff/BazelClient.java b/src/main/java/com/bazel_diff/BazelClient.java
@@ -52,7 +52,7 @@ public Set<String> queryForImpactedTargets(Set<String> impactedTargets, String a
         String targetQuery = impactedTargets.stream()
                                             .map(target -> String.format("'%s'", target))
                                             .collect(Collectors.joining(" + "));
-        String query = String.format("rdeps(//..., %s)", targetQuery);
+        String query = String.format("rdeps(//... except '//external:all-targets', %s)", targetQuery);
         if (avoidQuery != null) {
             query = String.format("(%s) except (%s)", query, avoidQuery);
         }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public Set<String> queryForImpactedTargets(Set<String> impactedTargets, String a`
`52`	`52`	`String targetQuery = impactedTargets.stream()`
`53`	`53`	`.map(target -> String.format("'%s'", target))`
`54`	`54`	`.collect(Collectors.joining(" + "));`
`55`		`- String query = String.format("rdeps(//..., %s)", targetQuery);`
	`55`	`+ String query = String.format("rdeps(//... except '//external:all-targets', %s)", targetQuery);`
`56`	`56`	`if (avoidQuery != null) {`
`57`	`57`	`query = String.format("(%s) except (%s)", query, avoidQuery);`
`58`	`58`	`}`