refactor: main_window.py #1244
Open
refactor: main_window.py #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored main_window.py by moving widgets to seperate classes as per the style guide.
Note that this requires move work so please leave your feedback on how this can be improved further.
Tasks Completed
I would also like to work on seperating the driver from the UI further by passing it to the respective classes and binding the callbacks within ui creation, if possible. In addition some of the new classes still include some logic that should be seperate. Perhaps we could write a controller only responsible for displaying content to lighten the load on ts_qt.py