Fix incorrect documentation about rollback behavior in database transactions section #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hohanov
changed the title
Author
|
Should I create a PR with the mentioned tests to the main repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation to correct the explanation of how database transactions interact with batch inserts. The previous description was inaccurate.
The issue was discussed here:
SpartnerNL/Laravel-Excel#4145
The behavior has been verified with tests on versions 3.1 and 4.x:
https://github.com/hohanov/Laravel-Excel/tree/3.1_test_can_roll_back_all_batches_on_error
https://github.com/hohanov/Laravel-Excel/tree/4.x_test_can_roll_back_all_batches_on_error
All batches are rolled back when an error occurs, even when batch inserts are enabled. The updated documentation now reflects the actual behavior.