move to package extension

Author: oscarddssmith

Project.toml

@@ -20,13 +20,15 @@ Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
 [weakdeps]
 Measurements = "eff96d63-e80a-5855-80a2-b1b0885c5ab7"
 MonteCarloMeasurements = "0987c9cc-fe09-11e8-30f0-b96dd679fdca"
+Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7"
 Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
 Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [extensions]
 RecursiveArrayToolsMeasurementsExt = "Measurements"
 RecursiveArrayToolsMonteCarloMeasurementsExt = "MonteCarloMeasurements"
 RecursiveArrayToolsTrackerExt = "Tracker"
+RecursiveArrayToolsSymbolicsExt = "Symbolics"
 RecursiveArrayToolsZygoteExt = "Zygote"
 
 [compat]

ext/RecursiveArrayToolsSymbolicsExt.jl

@@ -0,0 +1,8 @@
+module RecursiveArrayToolsSymbolicsExt
+
+import RecursiveArrayTools
+isdefined(Base, :get_extension) ? (import Symbolics) : (import ..Symbolics)
+
+RecursiveArrayTools.issymbollike(::Symbolics.Num) = true
+
+end

src/RecursiveArrayTools.jl

@@ -32,6 +32,7 @@ import Requires
 @static if !isdefined(Base, :get_extension)
     function __init__()
         Requires.@require Measurements="eff96d63-e80a-5855-80a2-b1b0885c5ab7" begin include("../ext/RecursiveArrayToolsMeasurementsExt.jl") end
+        Requires.@require Symbolics="e88e6eb3-aa80-5325-afca-941959d7151f" begin include("../ext/RecursiveArrayToolsSymbolicsExt.jl") end
         Requires.@require Tracker="9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c" begin include("../ext/RecursiveArrayToolsTrackerExt.jl") end
         Requires.@require Zygote="e88e6eb3-aa80-5325-afca-941959d7151f" begin include("../ext/RecursiveArrayToolsZygoteExt.jl") end
     end

src/vector_of_array.jl

@@ -64,11 +64,9 @@ end
 struct AllObserved
 end
 
-function issymbollike(x)
-    x isa Union{Symbol, AllObserved} && return true
-    ss = (:Operation, :Variable, :Sym, :Num, :Term)
-    return typeof(x).name.name in ss
-end
+# extended by Symbolcs
+issymbollike(::Any) = false
+issymbollike(::Union{Symbol, AllObserved}) = true
 
 function Base.Array(VA::AbstractVectorOfArray{T, N, A}) where {T, N,
                                                                A <: AbstractVector{

test/downstream/Project.toml

@@ -2,12 +2,14 @@
 ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
 MonteCarloMeasurements = "0987c9cc-fe09-11e8-30f0-b96dd679fdca"
 OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
-Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
+RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
+Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7"
 Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
+Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
 
 [compat]
 ModelingToolkit = "8.33"
 MonteCarloMeasurements = "1.1"
 OrdinaryDiffEq = "6.31"
+Tracker = "0.2"
 Unitful = "1.17"
-Tracker = "0.2"

test/downstream/SymbolicsExt.jl

@@ -0,0 +1,4 @@
+using RecursiveArrayTools, Symbolics, Test
+
+@variables x;
+@test RecursiveArrayTools.issymbollike(x)