revert to original behaviour of having black legend labels for invisible handles; can pass empty string " " to achieve empty/invisible label instead; having a black legend label by default allows the creation of neutrally coloured dummy entries

Author: lukashergt

lib/matplotlib/legend.py

@@ -618,8 +618,6 @@ def __init__(
                         break
                     except AttributeError:
                         continue
-                else:
-                    text.set_color('none')
         elif cbook._str_equal(labelcolor, 'none'):
             for text in self.texts:
                 text.set_color(labelcolor)

lib/matplotlib/tests/test_legend.py

@@ -1240,16 +1240,11 @@ def test_legend_labelcolor_linecolor_plot():
     assert mpl.colors.same_color(tc, p[0].get_markerfacecolor())
 
     fig, ax = plt.subplots()
-    p = ax.plot(x, 'o', c='none', mec='none', label="invisible circles and label")
+    p = ax.plot(x, 'o', c='none', mec='none',
+                label="black label despite invisible circles for dummy entries")
     leg = ax.legend(labelcolor='linecolor')
     tc = leg.texts[0].get_color()
-    assert mpl.colors.same_color(tc, 'none')
-    assert mpl.colors.same_color(tc, leg.get_lines()[0].get_markerfacecolor())
-    assert mpl.colors.same_color(tc, leg.get_lines()[0].get_markeredgecolor())
-    assert mpl.colors.same_color(tc, leg.get_lines()[0].get_color())
-    assert mpl.colors.same_color(tc, p[0].get_markerfacecolor())
-    assert mpl.colors.same_color(tc, p[0].get_markeredgecolor())
-    assert mpl.colors.same_color(tc, p[0].get_color())
+    assert mpl.colors.same_color(tc, 'k')
     plt.close('all')
 
 
@@ -1299,10 +1294,11 @@ def test_legend_labelcolor_linecolor_scatter():
     assert mpl.colors.same_color(tc, p.get_facecolor())
 
     fig, ax = plt.subplots()
-    p = ax.scatter(x, x, c='none', ec='none', label="invisible circles and label")
+    p = ax.scatter(x, x, c='none', ec='none',
+                   label="black label despite invisible circles for dummy entries")
     leg = ax.legend(labelcolor='linecolor')
     tc = leg.texts[0].get_color()
-    assert mpl.colors.same_color(tc, 'none')
+    assert mpl.colors.same_color(tc, 'k')
     plt.close('all')