refactory: controller 간소화

Author: ImGdevel

ProjectVG.Api/Controllers/AuthController.cs

@@ -1,6 +1,8 @@
 using Microsoft.AspNetCore.Mvc;
 using ProjectVG.Application.Services.User;
 using ProjectVG.Application.Models.User;
+using ProjectVG.Api.Models.Auth.Request;
+using ProjectVG.Api.Models.Auth.Response;
 
 namespace ProjectVG.Api.Controllers
 {
@@ -17,191 +19,62 @@ public AuthController(IUserService userService, ILogger<AuthController> logger)
             _logger = logger;
         }
 
-        /// <summary>
-        /// 회원가입
-        /// </summary>
         [HttpPost("register")]
-        public async Task<ActionResult<AuthResponseDto>> Register([FromBody] RegisterRequestDto request)
+        public async Task<ActionResult<AuthResponse>> Register([FromBody] RegisterRequest request)
         {
-            try
+            var userDto = request.ToUserDto();
+            var createdUser = await _userService.CreateUserAsync(userDto);
+            
+            var response = new AuthResponse
             {
-                if (!ModelState.IsValid)
-                {
-                    return BadRequest(ModelState);
-                }
-
-                var userDto = new UserDto
-                {
-                    Username = request.Username,
-                    Name = request.Name,
-                    Email = request.Email,
-                    Provider = "local",
-                    ProviderId = request.Username,
-                    IsActive = true
-                };
-
-                var createdUser = await _userService.CreateUserAsync(userDto);
-                
-                var response = new AuthResponseDto
-                {
-                    Success = true,
-                    Message = "회원가입이 완료되었습니다.",
-                    UserId = createdUser.Id,
-                    Username = createdUser.Username,
-                    Email = createdUser.Email
-                };
-
-                _logger.LogInformation("새 사용자 회원가입 완료: {Username}", createdUser.Username);
-                return Ok(response);
-            }
-            catch (InvalidOperationException ex)
-            {
-                return BadRequest(new AuthResponseDto
-                {
-                    Success = false,
-                    Message = ex.Message
-                });
-            }
-            catch (Exception ex)
-            {
-                _logger.LogError(ex, "회원가입 중 오류가 발생했습니다");
-                return StatusCode(500, new AuthResponseDto
-                {
-                    Success = false,
-                    Message = "회원가입 중 내부 서버 오류가 발생했습니다."
-                });
-            }
+                Success = true,
+                Message = "회원가입이 완료되었습니다.",
+                UserId = createdUser.Id,
+                Username = createdUser.Username,
+                Email = createdUser.Email
+            };
+
+            _logger.LogInformation("새 사용자 회원가입 완료: {Username}", createdUser.Username);
+            return Ok(response);
         }
 
-        /// <summary>
-        /// 로그인
-        /// </summary>
         [HttpPost("login")]
-        public async Task<ActionResult<AuthResponseDto>> Login([FromBody] LoginRequestDto request)
+        public async Task<ActionResult<AuthResponse>> Login([FromBody] LoginRequest request)
         {
-            try
-            {
-                if (!ModelState.IsValid)
-                {
-                    return BadRequest(ModelState);
-                }
-
-                // 사용자명으로 사용자 조회
-                var user = await _userService.GetUserByUsernameAsync(request.Username);
-                if (user == null)
-                {
-                    return Unauthorized(new AuthResponseDto
-                    {
-                        Success = false,
-                        Message = "사용자명 또는 비밀번호가 올바르지 않습니다."
-                    });
-                }
-
-                // TODO: 실제 비밀번호 검증 로직 추가 필요
-
-                var response = new AuthResponseDto
-                {
-                    Success = true,
-                    Message = "로그인이 완료되었습니다.",
-                    UserId = user.Id,
-                    Username = user.Username,
-                    Email = user.Email
-                };
-
-                _logger.LogInformation("사용자 로그인 완료: {Username}", user.Username);
-                return Ok(response);
-            }
-            catch (Exception ex)
+            var user = await _userService.GetUserByUsernameAsync(request.Username);
+            var response = new AuthResponse
             {
-                _logger.LogError(ex, "로그인 중 오류가 발생했습니다");
-                return StatusCode(500, new AuthResponseDto
-                {
-                    Success = false,
-                    Message = "로그인 중 내부 서버 오류가 발생했습니다."
-                });
-            }
+                Success = true,
+                Message = "로그인이 완료되었습니다.",
+                UserId = user.Id,
+                Username = user.Username,
+                Email = user.Email
+            };
+
+            _logger.LogInformation("사용자 로그인 완료: {Username}", user.Username);
+            return Ok(response);
         }
 
-        /// <summary>
-        /// 사용자명 중복 확인
-        /// </summary>
         [HttpGet("check-username/{username}")]
-        public async Task<ActionResult<CheckResponseDto>> CheckUsername(string username)
+        public async Task<ActionResult<CheckResponse>> CheckUsername(string username)
         {
-            try
-            {
-                var exists = await _userService.UsernameExistsAsync(username);
-                return Ok(new CheckResponseDto
-                {
-                    Exists = exists,
-                    Message = exists ? "이미 사용 중인 사용자명입니다." : "사용 가능한 사용자명입니다."
-                });
-            }
-            catch (Exception ex)
+            var exists = await _userService.UsernameExistsAsync(username);
+            return Ok(new CheckResponse
             {
-                _logger.LogError(ex, "사용자명 중복 확인 중 오류가 발생했습니다");
-                return StatusCode(500, new CheckResponseDto
-                {
-                    Exists = false,
-                    Message = "중복 확인 중 내부 서버 오류가 발생했습니다."
-                });
-            }
+                Exists = exists,
+                Message = exists ? "이미 사용 중인 사용자명입니다." : "사용 가능한 사용자명입니다."
+            });
         }
 
-        /// <summary>
-        /// 이메일 중복 확인
-        /// </summary>
         [HttpGet("check-email/{email}")]
-        public async Task<ActionResult<CheckResponseDto>> CheckEmail(string email)
+        public async Task<ActionResult<CheckResponse>> CheckEmail(string email)
         {
-            try
-            {
-                var exists = await _userService.EmailExistsAsync(email);
-                return Ok(new CheckResponseDto
-                {
-                    Exists = exists,
-                    Message = exists ? "이미 사용 중인 이메일입니다." : "사용 가능한 이메일입니다."
-                });
-            }
-            catch (Exception ex)
+            var exists = await _userService.EmailExistsAsync(email);
+            return Ok(new CheckResponse
             {
-                _logger.LogError(ex, "이메일 중복 확인 중 오류가 발생했습니다");
-                return StatusCode(500, new CheckResponseDto
-                {
-                    Exists = false,
-                    Message = "중복 확인 중 내부 서버 오류가 발생했습니다."
-                });
-            }
+                Exists = exists,
+                Message = exists ? "이미 사용 중인 이메일입니다." : "사용 가능한 이메일입니다."
+            });
         }
     }
-
-    // DTO 클래스들
-    public class RegisterRequestDto
-    {
-        public string Username { get; set; } = string.Empty;
-        public string Name { get; set; } = string.Empty;
-        public string Email { get; set; } = string.Empty;
-        public string Password { get; set; } = string.Empty;
-    }
-
-    public class LoginRequestDto
-    {
-        public string Username { get; set; } = string.Empty;
-        public string Password { get; set; } = string.Empty;
-    }
-
-    public class AuthResponseDto
-    {
-        public bool Success { get; set; }
-        public string Message { get; set; } = string.Empty;
-        public Guid? UserId { get; set; }
-        public string? Username { get; set; }
-        public string? Email { get; set; }
-    }
-
-    public class CheckResponseDto
-    {
-        public bool Exists { get; set; }
-        public string Message { get; set; } = string.Empty;
-    }
 } 

ProjectVG.Api/Controllers/CharacterController.cs

@@ -22,115 +22,42 @@ public CharacterController(ICharacterService characterService, ILogger<Character
         [HttpGet]
         public async Task<ActionResult<IEnumerable<CharacterResponse>>> GetAllCharacters()
         {
-            try
-            {
-                var characterDtos = await _characterService.GetAllCharactersAsync();
-                var responses = characterDtos.Select(CharacterResponse.ToResponseDto);
-                return Ok(responses);
-            }
-            catch (Exception ex)
-            {
-                _logger.LogError(ex, "모든 캐릭터 조회 중 오류가 발생했습니다");
-                return StatusCode(500, "캐릭터 목록을 가져오는 중 내부 서버 오류가 발생했습니다.");
-            }
+            var characterDtos = await _characterService.GetAllCharactersAsync();
+            var responses = characterDtos.Select(CharacterResponse.ToResponseDto);
+            return Ok(responses);
         }
 
         [HttpGet("{id}")]
         public async Task<ActionResult<CharacterResponse>> GetCharacterById(Guid id)
         {
-            try
-            {
-                var characterDto = await _characterService.GetCharacterByIdAsync(id);
-                if (characterDto == null)
-                {
-                    return NotFound($"ID {id}인 캐릭터를 찾을 수 없습니다.");
-                }
-
-                var response = CharacterResponse.ToResponseDto(characterDto);
-                return Ok(response);
-            }
-            catch (Exception ex)
-            {
-                _logger.LogError(ex, "ID {CharacterId}인 캐릭터 조회 중 오류가 발생했습니다", id);
-                return StatusCode(500, "캐릭터 정보를 가져오는 중 내부 서버 오류가 발생했습니다.");
-            }
+            var characterDto = await _characterService.GetCharacterByIdAsync(id);
+            var response = CharacterResponse.ToResponseDto(characterDto);
+            return Ok(response);
         }
 
         [HttpPost]
         public async Task<ActionResult<CharacterResponse>> CreateCharacter([FromBody] CreateCharacterRequest request)
         {
-            try
-            {
-                if (!ModelState.IsValid)
-                {
-                    return BadRequest(ModelState);
-                }
-
-                var command = new CreateCharacterCommand
-                {
-                    Name = request.Name,
-                    Description = request.Description,
-                    Role = request.Role,
-                    IsActive = request.IsActive
-                };
-
-                var characterDto = await _characterService.CreateCharacterAsync(command);
-                var response = CharacterResponse.ToResponseDto(characterDto);
-                return CreatedAtAction(nameof(GetCharacterById), new { id = response.Id }, response);
-            }
-            catch (Exception ex)
-            {
-                _logger.LogError(ex, "캐릭터 생성 중 오류가 발생했습니다");
-                return StatusCode(500, "캐릭터 생성 중 내부 서버 오류가 발생했습니다.");
-            }
+            var command = request.ToCreateCharacterCommand();
+            var characterDto = await _characterService.CreateCharacterAsync(command);
+            var response = CharacterResponse.ToResponseDto(characterDto);
+            return CreatedAtAction(nameof(GetCharacterById), new { id = response.Id }, response);
         }
 
         [HttpPut("{id}")]
         public async Task<ActionResult<CharacterResponse>> UpdateCharacter(Guid id, [FromBody] UpdateCharacterRequest request)
         {
-            try
-            {
-                if (!ModelState.IsValid)
-                {
-                    return BadRequest(ModelState);
-                }
-
-                var command = new UpdateCharacterCommand
-                {
-                    Name = request.Name,
-                    Description = request.Description,
-                    Role = request.Role,
-                    IsActive = request.IsActive
-                };
-
-                var characterDto = await _characterService.UpdateCharacterAsync(id, command);
-                var response = CharacterResponse.ToResponseDto(characterDto);
-                return Ok(response);
-            }
-            catch (KeyNotFoundException)
-            {
-                return NotFound($"ID {id}인 캐릭터를 찾을 수 없습니다.");
-            }
-            catch (Exception ex)
-            {
-                _logger.LogError(ex, "ID {CharacterId}인 캐릭터 수정 중 오류가 발생했습니다", id);
-                return StatusCode(500, "캐릭터 정보 수정 중 내부 서버 오류가 발생했습니다.");
-            }
+            var command = request.ToUpdateCharacterCommand();
+            var characterDto = await _characterService.UpdateCharacterAsync(id, command);
+            var response = CharacterResponse.ToResponseDto(characterDto);
+            return Ok(response);
         }
 
         [HttpDelete("{id}")]
         public async Task<ActionResult> DeleteCharacter(Guid id)
         {
-            try
-            {
-                await _characterService.DeleteCharacterAsync(id);
-                return NoContent();
-            }
-            catch (Exception ex)
-            {
-                _logger.LogError(ex, "ID {CharacterId}인 캐릭터 삭제 중 오류가 발생했습니다", id);
-                return StatusCode(500, "캐릭터 삭제 중 내부 서버 오류가 발생했습니다.");
-            }
+            await _characterService.DeleteCharacterAsync(id);
+            return NoContent();
         }
     }
 } 

ProjectVG.Api/Controllers/HomeController.cs

@@ -39,6 +39,9 @@ public IActionResult TestException(string type)
                 "notfound" => throw new NotFoundException(ErrorCode.NOT_FOUND, "테스트 리소스를 찾을 수 없습니다"),
                 "validation" => throw new ValidationException(ErrorCode.VALIDATION_FAILED, "유효성 검사 실패"),
                 "external" => throw new ExternalServiceException("테스트서비스", "http://test.com/api", "외부 서비스 오류", ErrorCode.EXTERNAL_SERVICE_ERROR),
+                "generic" => throw new InvalidOperationException("일반적인 시스템 오류가 발생했습니다"),
+                "nullref" => throw new NullReferenceException("널 참조 오류가 발생했습니다"),
+                "divide" => throw new DivideByZeroException("0으로 나누기 오류가 발생했습니다"),
                 _ => throw new ProjectVGException(ErrorCode.BAD_REQUEST, "알 수 없는 예외 타입", 400)
             };
         }