Skip to content

Commit f493ecd

Browse files
8620 modulenotfounderror no module named onnxscript in test py3x 311 pipeline (#8638)
Fixes #8620 . ### Description Adds `onnxscript` as an explicit dependency. I have tried to find where this onnxscript package was coming from before. For that, I tried all Python versions from 3.9 to 3.12, all versions of onnxruntime and onnx_graphsurgeon, and all versions later than 1.13.0 of onnx. None of these would include `onnxscript`. I suppose that this was a requirement of another library and was removed in some new version. I don't think it is worth the trouble of further investigating to find which package it was, since we wouldn't want to freeze a package version for this reason. So, instead, I propose we just add onnxscript as a dependency. ### Potential issue I am not sure if this will trigger the running of the ONNX tests in Python < 3.10 and how it will impact those tests. A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com> Signed-off-by: Rafael Garcia-Dias <rafaelagd@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 9a45627 commit f493ecd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

requirements-dev.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ h5py
5151
nni==2.10.1; platform_system == "Linux" and "arm" not in platform_machine and "aarch" not in platform_machine
5252
optuna
5353
git+https://github.com/Project-MONAI/MetricsReloaded@monai-support#egg=MetricsReloaded
54-
onnx>=1.13.0, <1.19.1
54+
onnx>=1.13.0
55+
onnxscript
5556
onnxruntime; python_version <= '3.10'
5657
typeguard<3 # https://github.com/microsoft/nni/issues/5457
5758
filelock<3.12.0 # https://github.com/microsoft/nni/issues/5523

0 commit comments

Comments
 (0)