Director daemon fails with unquoted special characters in resources.ini

[afeefghannam89]

When there is an unquoted string containing special characters anywhere in the icingaweb2 resources.ini file, regardless in which resource section, the Director daemon will fail to start with the error "DB configuration is not valid". It seems that the Director validates the entire resource.ini file, not only its own database section.

The template ini_template.j2 places quotes around a string only when it contains =, !, or a space (" "). However, there are passwords that do not include these characters but do contain others, such as }, [, ?, and so on.

I believe icingaweb2 quotes all values in the resource.ini file. Wouldn’t it be better to follow Icinga Web’s standard parsing behavior instead of handling each value type differently?

[afeefghannam89]

When there is a place, where Icingaweb does not quotes the values, you can use something like:

{% elif value is string and value is search('[^a-zA-Z0-9_]') %}

[Donien]

As we talked about this, it seems not all special characters lead to a problem.
Also, the Director seems to look at its own database resource and the one of Icinga Web itself.
Others don't seem to be of concern to the Director.

Regardless, I think we should take the route you suggested (always quoting).
I've created a PR (#427) if you'd like to test it. The change seems simple enough, though.