Use extension method to assert no errors on api response

Author: Matthiee

Tests/ApiResponseExtensions.cs

@@ -0,0 +1,15 @@
+using MatthiWare.FinancialModelingPrepApi.Model;
+using Xunit;
+
+namespace Tests
+{
+    public static class ApiResponseExtensions
+    {
+        public static void AssertNoErrors<T>(this ApiResponse<T> response)
+            where T : class
+        {
+            Assert.NotNull(response);
+            Assert.False(response.HasError, response.Error);
+        }
+    }
+}

Tests/CompanyValuation/CompanyValuationTests.cs

@@ -21,8 +21,7 @@ public async Task GetCompanyProfileTests()
 
             var result = await api.CompanyValuation.GetCompanyProfileAsync("AAPL");
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.Equal("AAPL", result.Data.symbol);
         }
 
@@ -44,8 +43,7 @@ public async Task GetSymbolsList()
 
             var result = await api.CompanyValuation.GetSymbolsListAsync();
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
         }
 
@@ -56,8 +54,7 @@ public async Task GetETFList()
 
             var result = await api.CompanyValuation.GetETFListAsync();
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
         }
 
@@ -68,8 +65,7 @@ public async Task GetTradableSymbolsList()
 
             var result = await api.CompanyValuation.GetTradableSymbolsListAsync();
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
         }
 
@@ -80,8 +76,7 @@ public async Task GetEnterpriseValue()
 
             var result = await api.CompanyValuation.GetEnterpriseValueAsync("AAPL", Period.Annual, 5);
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
             Assert.Equal(5, result.Data.Count);
             Assert.All(result.Data, data => Assert.Equal("AAPL", data.symbol));
@@ -94,8 +89,7 @@ public async Task GetIncomeStatement()
 
             var result = await api.CompanyValuation.GetIncomeStatementAsync("AAPL", Period.Annual, 5);
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
             Assert.Equal(5, result.Data.Count);
             Assert.All(result.Data, data => Assert.Equal("AAPL", data.Symbol));
@@ -108,8 +102,7 @@ public async Task GetCashFlowStatement()
 
             var result = await api.CompanyValuation.GetCashFlowStatementAsync("AAPL", Period.Annual, 5);
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
             Assert.Equal(5, result.Data.Count);
             Assert.All(result.Data, data => Assert.Equal("AAPL", data.Symbol));
@@ -122,8 +115,7 @@ public async Task GetBalanceSheetStatement()
 
             var result = await api.CompanyValuation.GetBalanceSheetStatementAsync("AAPL", Period.Annual, 5);
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
             Assert.Equal(5, result.Data.Count);
             Assert.All(result.Data, data => Assert.Equal("AAPL", data.Symbol));
@@ -136,8 +128,7 @@ public async Task GetStockNewsAsync()
 
             var result = await api.CompanyValuation.GetStockNewsAsync("AAPL", 5);
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
             Assert.Equal(5, result.Data.Count);
             Assert.All(result.Data, data => Assert.Equal("AAPL", data.Symbol));
@@ -150,8 +141,7 @@ public async Task GetCompanyRatingAsync()
 
             var result = await api.CompanyValuation.GetCompanyRatingAsync("AAPL");
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.Equal("AAPL", result.Data.Symbol);
         }
 
@@ -162,8 +152,7 @@ public async Task GetHistoricalCompanyRatingAsync()
 
             var result = await api.CompanyValuation.GetHistoricalCompanyRatingAsync("AAPL", 5);
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
             Assert.Equal(5, result.Data.Count);
             Assert.All(result.Data, data => Assert.Equal("AAPL", data.Symbol));

Tests/MarketIndexes/MarketIndexesTests.cs

@@ -20,8 +20,7 @@ public async Task GetDowJonesCompaniesTests()
 
             var result = await api.MarketIndexes.GetDowJonesCompaniesAsync();
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
         }
 
@@ -32,8 +31,7 @@ public async Task GetNasdaqCompaniesTests()
 
             var result = await api.MarketIndexes.GetNasdaqCompaniesAsync();
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
         }
 
@@ -44,8 +42,7 @@ public async Task GetSP500CompaniesTests()
 
             var result = await api.MarketIndexes.GetSP500CompaniesAsync();
 
-            Assert.NotNull(result);
-            Assert.False(result.HasError);
+            result.AssertNoErrors();
             Assert.NotEmpty(result.Data);
         }
     }