fix(client): use type-only imports for @modelcontextprotocol/sdk types #157
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change value imports to `import type` syntax for SDK types to prevent bundlers from including Node.js server code in browser builds. When bundling @mcp-ui/client for pure browser environments, the @modelcontextprotocol/sdk's server-side code (which imports Express) was being included due to the import chain, causing "require is not defined" errors at runtime. Since the SDK is only used for TypeScript types (not runtime values), using `import type` ensures these imports are stripped at compile time and don't trigger bundling of the SDK's server-side modules. Files changed: - UIResourceRendererWC.tsx: EmbeddedResource type - metadataUtils.ts: Resource type - processResource.ts: EmbeddedResource, Resource types - UIResourceRenderer.unmocked.test.tsx: EmbeddedResource type 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change value imports to
import typesyntax for SDK types to prevent bundlers from including Node.js server code in browser builds.When bundling @mcp-ui/client for pure browser environments, the @modelcontextprotocol/sdk's server-side code (which imports Express) was being included due to the import chain, causing "require is not defined" errors at runtime.
Since the SDK is only used for TypeScript types (not runtime values), using
import typeensures these imports are stripped at compile time and don't trigger bundling of the SDK's server-side modules.Files changed:
🤖 Generated with Claude Code