From 9f0771dd0436ec58893ba895c148daaca490e0be Mon Sep 17 00:00:00 2001 From: comfort Date: Sun, 20 Oct 2024 10:46:15 +0200 Subject: [PATCH] Completed the basic laravel validation exercises --- app/Http/Controllers/BuildingController.php | 2 +- app/Http/Controllers/PostController.php | 7 +++-- app/Http/Controllers/ProfileController.php | 2 ++ app/Http/Controllers/UserController.php | 3 ++- app/Http/Requests/StoreBuildingRequest.php | 6 +++++ app/Http/Requests/StoreItemRequest.php | 29 +++++++++++++++++++++ app/Rules/Uppercase.php | 21 +++++++++++++++ resources/views/products/create.blade.php | 4 +++ resources/views/projects/create.blade.php | 8 ++++++ resources/views/teams/create.blade.php | 2 +- 10 files changed, 77 insertions(+), 7 deletions(-) create mode 100644 app/Http/Requests/StoreItemRequest.php create mode 100644 app/Rules/Uppercase.php diff --git a/app/Http/Controllers/BuildingController.php b/app/Http/Controllers/BuildingController.php index 9c752ab8..875b4cbb 100644 --- a/app/Http/Controllers/BuildingController.php +++ b/app/Http/Controllers/BuildingController.php @@ -17,7 +17,7 @@ public function create() // TASK: Customize the validation error message to say "Please enter the name" public function store(StoreBuildingRequest $request) { - Building::create($validator->validated()); + Building::create($request->validated()); return 'Success'; } diff --git a/app/Http/Controllers/PostController.php b/app/Http/Controllers/PostController.php index cd0808b7..b065b04c 100644 --- a/app/Http/Controllers/PostController.php +++ b/app/Http/Controllers/PostController.php @@ -9,10 +9,9 @@ class PostController extends Controller { public function store(Request $request) { - $request->validate( - // ... TASK: write validation here so that "title" field - // would be required and unique in the "posts" DB table - ); + $request->validate([ + 'title' => 'required|unique:App\Models\Post' + ]); // Saving the post Post::create(['title' => $request->title]); diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php index bb6bab39..35e8ba02 100644 --- a/app/Http/Controllers/ProfileController.php +++ b/app/Http/Controllers/ProfileController.php @@ -13,6 +13,8 @@ public function update(Request $request) // // // Write validation rules, so both name and email are required + "profile.name" => "required", + "profile.email" => "required", ]); auth()->user()->update($request->profile ?? []); diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php index 404d7471..f9746665 100644 --- a/app/Http/Controllers/UserController.php +++ b/app/Http/Controllers/UserController.php @@ -11,7 +11,8 @@ public function update(User $user, UpdateUserRequest $request) { // TASK: change this line to not allow is_admin field to be updated // Update only the fields that are validated in UpdateUserRequest - $user->update($request->all()); + $validated = $request->safe()->only(['name', 'email']); + $user->update($validated); return 'Success'; } diff --git a/app/Http/Requests/StoreBuildingRequest.php b/app/Http/Requests/StoreBuildingRequest.php index fbd8c064..6a4834bb 100644 --- a/app/Http/Requests/StoreBuildingRequest.php +++ b/app/Http/Requests/StoreBuildingRequest.php @@ -30,4 +30,10 @@ public function rules() 'name' => 'required' ]; } + + public function messages() : array { + return [ + 'name.required' => 'Please enter the name' + ]; + } } diff --git a/app/Http/Requests/StoreItemRequest.php b/app/Http/Requests/StoreItemRequest.php new file mode 100644 index 00000000..6461d85e --- /dev/null +++ b/app/Http/Requests/StoreItemRequest.php @@ -0,0 +1,29 @@ + + */ + public function rules(): array + { + return [ + 'name'=> 'required', + 'description'=> 'required', + ]; + } +} diff --git a/app/Rules/Uppercase.php b/app/Rules/Uppercase.php new file mode 100644 index 00000000..e8821e39 --- /dev/null +++ b/app/Rules/Uppercase.php @@ -0,0 +1,21 @@ +
diff --git a/resources/views/projects/create.blade.php b/resources/views/projects/create.blade.php index dc19b63b..f608a292 100644 --- a/resources/views/projects/create.blade.php +++ b/resources/views/projects/create.blade.php @@ -4,6 +4,14 @@ {{-- in case of title/description empty, visitor should see --}} {{-- "The name field is required." and "The description field is required." --}} +@if ($errors->any()) + +@endif +
@csrf Title: diff --git a/resources/views/teams/create.blade.php b/resources/views/teams/create.blade.php index 2d003c05..f1afdef2 100644 --- a/resources/views/teams/create.blade.php +++ b/resources/views/teams/create.blade.php @@ -3,7 +3,7 @@ Name:
{{-- TASK: change this field so it would contain old value after validation error --}} - +