#58870 issue: Updated the Check for isfile (path) #60274
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Dec 5, 2025
| contains(line, r"\S") && (non_blank = lineno) | ||
|
|
||
|
|
||
| local is_regular_file = false |
Member
There was a problem hiding this comment.
Indentation looks wrong here.
Member
|
It would be better to fix the underlying issue; see #58870 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I updated the isfile check in the process where the code doesn't crashes in windows when the permission is denied
it just simply ignore the file and assume that file doesn't exist and run the code further