Area of preview on hover should be shrink to the size of the text displayed #14478

samol123456 · 2025-11-30T21:18:34Z

This PR improves the sizing behavior of the entry-table tooltip when the preview feature is enabled.
Previously, the tooltip became significantly larger than the actual preview content due to missing layout constraints.
The fix adjusts the tooltip container and the PreviewViewer sizing logic so the tooltip now adapts to its preferred size and remains compact.

Steps to test

Open Preferences → Entry preview.

Enable: “Show preview in entry table tooltip”.

Hover over any entry in the main table.

Observe that the tooltip now:

matches the size of the preview content,

no longer grows excessively,

remains readable and compact.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

…rador-commits/jabref into fix-for-issue-12351

github-actions · 2025-11-30T21:18:43Z

Hey @samol123456!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️

We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

koppor

Does not work with Chocolate.bib

Scrollbar appears at longer entry previews:

samol123456 · 2025-11-30T23:55:30Z

Okay we are going to fix it

subhramit · 2025-12-02T23:57:25Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+                Object heightObj = previewView.getEngine().executeScript("document.getElementById('content').scrollHeight || document.body.scrollHeight");
+                Object widthObj = previewView.getEngine().executeScript("document.getElementById('content').scrollWidth || document.body.scrollWidth");


Not sure, but I think there should be a neater way to do this

What the comment means - where did you get the hint from? What alternatives did you consider?

subhramit · 2025-12-02T23:58:57Z

jabgui/src/test/java/org/jabref/gui/preview/PreviewViewerReflectionTest.java

+/**
+ * Lightweight tests that ensure the PreviewViewer exposes content size properties
+ * used by UI components for adaptive-sizing (reflections avoid needing a JavaFX runtime here).
+ */
+public class PreviewViewerReflectionTest {
+
+    @Test
+    public void contentPropertiesExist() throws Exception {
+        Class<?> clazz = PreviewViewer.class;
+
+        Method heightMethod = clazz.getMethod("contentHeightProperty");
+        assertEquals(ReadOnlyDoubleProperty.class, heightMethod.getReturnType());
+
+        Method widthMethod = clazz.getMethod("contentWidthProperty");
+        assertEquals(ReadOnlyDoubleProperty.class, widthMethod.getReturnType());


These tests are AI-generated and make no sense in context of the changed functionality

subhramit · 2025-12-02T23:59:51Z

jabgui/src/main/java/org/jabref/gui/maintable/MainTableTooltip.java

+        final double MIN_TOOLTIP_WIDTH = 200.0; // Minimum width of the tooltip to keep layout stable even with small content
+
+        preview.contentHeightProperty().addListener((_, _, val) -> {
+            double contentH = val == null ? 0 : val.doubleValue();


Use full variable names - contentHeight, contentWidth etc

…ionTest.java

koppor · 2025-12-03T21:49:01Z

@samol123456 Please use English words for commit messages (in future)

koppor · 2025-12-03T23:32:33Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+    /**
+     * Expose the measured content height of the rendered preview. Value is in CSS pixels.
+     */


I don't think that "measured" is right - remove the whole comment.

koppor · 2025-12-03T23:32:41Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+    /**
+     * Expose the measured content width of the rendered preview. Value is in CSS pixels.
+     */


I don't think that "measured" is right - remove the whole comment.

koppor · 2025-12-03T23:33:34Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+
+                javafx.application.Platform.runLater(() -> {
+                    optHeight.ifPresent(h -> {
+                        // small padding so the rendered content is not clipped at edges


comment is off by one line.

Use "speaking" variable names: height instead of h

koppor · 2025-12-03T23:35:55Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+                Optional<Double> optHeight = Optional.ofNullable(height);
+                Optional<Double> optWidth = Optional.ofNullable(width);


Not sure if this is more readable in this case. - you should use optionals in the whole method - and not switch from null to Optionals. -- Using null is OK as altternative. But do not mix.

koppor · 2025-12-05T22:27:09Z

jabgui/src/main/java/org/jabref/gui/maintable/MainTableTooltip.java

+        final double previewWidthPadding = 16.0;
+        final double PREVIEW_HEIGHT_PADDING = 8.0;  // Padding to avoid bottom clipping of the preview
+        final double MIN_TOOLTIP_WIDTH = 200.0; // Minimum width of the tooltip to keep layout stable even with small content


You do see that you case the final variables differently, don't you?

koppor · 2025-12-05T22:27:49Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+                        this.setPrefHeight(h + 8);
+                    });
+                    optWidth.ifPresent(w -> {
+                        contentWidth.set(w);
+                        this.setPrefWidth(w + 8);


You do see that you did not use the constant from above?

koppor · 2025-12-05T22:28:03Z

jabgui/src/main/java/org/jabref/gui/preview/PreviewViewer.java

+                });
+
+                setHvalue(0);
+            } catch (Exception e) {


Please list the exceptions explicitely (JabRef style)

koppor · 2025-12-05T23:46:01Z

jabgui/src/main/java/module-info.java

    // requires mslinks;
    requires org.antlr.antlr4.runtime;
    requires org.libreoffice.uno;
+    requires java.scripting;


You do know what "alphabetically" means?

Yes,
But I did not touch this file

https://github.com/JabRef/jabref/pull/14478/files shows it.

I assume IntelliJ might have added it - maybe, you can just remove it?

Mbungai-Francesco and others added 17 commits November 4, 2025 22:23

BitEntryClass created

c4db0b1

resolution issue v1

5dd02dd

retrait de ligne de code inutile

48ee9d5

retrait de ligne de code inutile

8d33da7

Merge branch 'JabRef:main' into fix-for-issue-12351

52c0f05

keMerge branch 'fix-for-issue-12351' of https://github.com/paulamalva…

4459622

…rador-commits/jabref into fix-for-issue-12351

change tooltipe size

696639a

Add changelog.md

5f2074d

Merge branch 'main' into fix-for-issue-12351

a0f688d

second attempst pull request issue 2

f2b66e7

Merge branch 'JabRef:main' into fix-for-issue-12351

4ad537b

rmv line

19a80ad

rmv import

4ab7398

rmv space2

71cc5f2

rmv files

083e413

Fix submodules

a5f412a

Merge branch 'JabRef:main' into fix-for-issue-12351

58e073b

github-actions bot added the first contrib label Nov 30, 2025

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 30, 2025

Merge branch 'main' into fix-for-issue-12351

7e52ab0

koppor requested changes Nov 30, 2025

View reviewed changes

github-actions bot added status: changes-required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 30, 2025

Assemien Olivia and others added 5 commits December 1, 2025 10:48

Modification

8fe53d8

Modification

ae2a21a

fix checkstyle

ad8c35c

Merge branch 'JabRef:main' into fix-for-issue-12351

dae4c68

fix indentation

5f9da86

adding comment et refactor some script

8ce5c92

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 2, 2025

fix checkstyle

fd1290d

github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 2, 2025

fix emptyline

4c9de0e

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 2, 2025

subhramit reviewed Dec 2, 2025

View reviewed changes

Modification des noms des variables et suppresion PreviewViewerRefect…

b1a3b5a

…ionTest.java

koppor reviewed Dec 3, 2025

View reviewed changes

koppor added the status: changes-required Pull requests that are not yet complete label Dec 4, 2025

comment deletion

3619d1b

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 5, 2025

koppor requested changes Dec 5, 2025

View reviewed changes

github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 5, 2025

rename variale h and w

59c42ff

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 5, 2025

Assemien Olivia added 3 commits December 6, 2025 00:13

correction of previewWidthPadding

fe245ff

list exceptions

a8b02aa

remove blank

ab4baee

github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 5, 2025

reformat code

42a8e43

koppor reviewed Dec 5, 2025

View reviewed changes

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Dec 5, 2025

remove java.scripting

d898c3b

		Object heightObj = previewView.getEngine().executeScript("document.getElementById('content').scrollHeight \|\| document.body.scrollHeight");
		Object widthObj = previewView.getEngine().executeScript("document.getElementById('content').scrollWidth \|\| document.body.scrollWidth");

		Optional<Double> optHeight = Optional.ofNullable(height);
		Optional<Double> optWidth = Optional.ofNullable(width);

Uh oh!

Area of preview on hover should be shrink to the size of the text displayed #14478

Are you sure you want to change the base?

Area of preview on hover should be shrink to the size of the text displayed #14478

Conversation

samol123456 commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

github-actions bot commented Nov 30, 2025

Hey @samol123456!

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

samol123456 commented Nov 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor commented Dec 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

samol123456 commented Nov 30, 2025 •

edited

Loading