Skip to content

Commit 2c01b94

Browse files
authored
Merge pull request #1321 from ImageEngine/tmpRB-10.3
Merge 10.3.8.1 onto RB-10.4
2 parents 7af432e + a969dae commit 2c01b94

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed

Changes

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
Fixes
2+
---
3+
4+
- IECoreMaya.SceneShapeSubSceneOverride : Visibility override fixes (#1320).
5+
- Removed SceneInterface visibility check, as it is now obsolete and causing issues.
6+
- Check visibility for root locations, so bounds aren't incorrectly drawn.
7+
18
10.4.3.0 (relative to 10.4.2.1)
29
========
310

@@ -135,6 +142,16 @@ Build
135142

136143
- Updated IE options file to support Nuke 13.x custom dependencies (#1263).
137144

145+
10.3.8.1 (relative to 10.3.8.0)
146+
========
147+
148+
Fixes
149+
---
150+
151+
- IECoreMaya.SceneShapeSubSceneOverride : Visibility override fixes (#1320).
152+
- Removed SceneInterface visibility check, as it is now obsolete and causing issues.
153+
- Check visibility for root locations, so bounds aren't incorrectly drawn.
154+
138155
10.3.8.0 (relative to 10.3.7.2)
139156
========
140157

src/IECoreMaya/SceneShapeSubSceneOverride.cpp

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,16 +1418,6 @@ void SceneShapeSubSceneOverride::visitSceneLocations( const SceneInterface *scen
14181418
return;
14191419
}
14201420

1421-
// respect visibility attribute
1422-
if( sceneInterface->hasAttribute( SceneInterface::visibilityName ) )
1423-
{
1424-
ConstBoolDataPtr vis = runTimeCast<const BoolData>( sceneInterface->readAttribute( SceneInterface::visibilityName, m_time ) );
1425-
if( vis && !vis->readable() )
1426-
{
1427-
return;
1428-
}
1429-
}
1430-
14311421
MMatrix accumulatedMatrix;
14321422
if( !isRoot )
14331423
{
@@ -1473,6 +1463,10 @@ void SceneShapeSubSceneOverride::visitSceneLocations( const SceneInterface *scen
14731463
int count = 0;
14741464
for( const auto &instance : m_instances )
14751465
{
1466+
if ( !instance.visible )
1467+
{
1468+
continue;
1469+
}
14761470
std::string instanceName = rootItemName + "_" + std::to_string( count++ );
14771471
MString itemName( instanceName.c_str() );
14781472
MRenderItem *renderItem = acquireRenderItem( container, IECore::NullObject::defaultNullObject(), instance, relativeLocation, bound, itemName, RenderStyle::BoundingBox );

0 commit comments

Comments
 (0)