Skip to content

Commit 592a16e

Browse files
author
soh boon keong
committed
fix log4j exploit
1 parent 1fb43a1 commit 592a16e

File tree

6 files changed

+38
-16
lines changed

6 files changed

+38
-16
lines changed

build.gradle

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,16 @@ dependencies {
1919

2020
//gradle 4.0
2121
compile group: 'commons-lang', name: 'commons-lang', version: '2.4'
22-
compile group: 'org.slf4j', name: 'slf4j-api', version: '1.7.25'
22+
//compile group: 'org.slf4j', name: 'slf4j-api', version: '1.7.25'
23+
compile group: 'org.apache.logging.log4j', name: 'log4j-api', version: '2.14.1'
24+
compile group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.14.1'
2325
compile group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.10.5.1'
2426
compile group: 'com.googlecode.json-simple', name: 'json-simple', version: '1.1.1'
2527
compile group: 'org.bouncycastle', name: 'bcpkix-jdk15on', version: '1.69'
26-
testCompile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.32'
28+
29+
//testCompile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.32'
30+
testCompile group: 'org.apache.logging.log4j', name: 'log4j-api', version: '2.14.1'
31+
testCompile group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.14.1'
2732
testCompile group: 'junit', name: 'junit', version: '4.13.1'
2833

2934
//gradle 6.9

pom.xml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,21 @@
7777
<version>1.3</version>
7878
<scope>test</scope>
7979
</dependency>
80-
<dependency>
80+
<!-- <dependency>
8181
<groupId>org.slf4j</groupId>
8282
<artifactId>slf4j-log4j12</artifactId>
8383
<version>1.7.32</version>
84-
</dependency>
84+
</dependency> -->
85+
<dependency>
86+
<groupId>org.apache.logging.log4j</groupId>
87+
<artifactId>log4j-api</artifactId>
88+
<version>2.14.1</version>
89+
</dependency>
90+
<dependency>
91+
<groupId>org.apache.logging.log4j</groupId>
92+
<artifactId>log4j-core</artifactId>
93+
<version>2.14.1</version>
94+
</dependency>
8595
<dependency>
8696
<groupId>commons-lang</groupId>
8797
<artifactId>commons-lang</artifactId>

src/main/java/com/api/util/ApiSecurity/ApiSigning.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
import org.bouncycastle.openssl.PEMParser;
88
import org.bouncycastle.openssl.jcajce.JcaPEMKeyConverter;
99
import org.bouncycastle.openssl.jcajce.JcePEMDecryptorProviderBuilder;
10-
import org.slf4j.Logger;
11-
import org.slf4j.LoggerFactory;
10+
import org.apache.logging.log4j.Logger;
11+
import org.apache.logging.log4j.LogManager;
1212

1313
import javax.crypto.Mac;
1414
import javax.crypto.spec.SecretKeySpec;
@@ -34,7 +34,7 @@
3434
*/
3535
public class ApiSigning {
3636

37-
private static final Logger log = LoggerFactory.getLogger(ApiSigning.class);
37+
private static final Logger log = LogManager.getLogger(ApiSigning.class);
3838

3939
/**
4040
* Create HMACRSA256 Signature (L1) with a given basestring

src/test/java/com/api/util/ApiSecurity/ApiSecurityTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@
1616
import java.util.Set;
1717

1818
import org.junit.runner.RunWith;
19-
import org.slf4j.Logger;
20-
import org.slf4j.LoggerFactory;
19+
//import org.slf4j.Logger;
20+
//import org.slf4j.LoggerFactory;
21+
import org.apache.logging.log4j.Logger;
22+
import org.apache.logging.log4j.LogManager;
2123

2224
import com.api.util.testframework.JUnitFactoryRunner;
2325
import com.api.util.testframework.JUnitTestFactory;
@@ -35,7 +37,8 @@
3537
@RunWith(JUnitFactoryRunner.class)
3638
public class ApiSecurityTest {
3739

38-
private static final Logger log = LoggerFactory.getLogger(ApiSecurityTest.class);
40+
//private static final Logger log = LoggerFactory.getLogger(ApiSecurityTest.class);
41+
private static final Logger log = LogManager.getLogger(ApiSecurityTest.class);
3942

4043
private static final String testDataPath = getLocalPath("src/main/resources/test-suites/testData/");
4144

src/test/java/com/api/util/testframework/RuntimeTestCase.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
package com.api.util.testframework;
22

3-
import org.slf4j.Logger;
4-
import org.slf4j.LoggerFactory;
3+
//import org.slf4j.Logger;
4+
//import org.slf4j.LoggerFactory;
5+
import org.apache.logging.log4j.Logger;
6+
import org.apache.logging.log4j.LogManager;
57

68
import com.api.util.ApiSecurity.ApiList;
79
import com.api.util.ApiSecurity.ApiSigning;
@@ -24,7 +26,7 @@
2426

2527
public class RuntimeTestCase{
2628

27-
private static final Logger log = LoggerFactory.getLogger(RuntimeTestCase.class);
29+
private static final Logger log = LogManager.getLogger(RuntimeTestCase.class);
2830

2931
//private ApiList apiList;
3032
private String testName;

src/test/java/com/api/util/testframework/RuntimeTestUtility.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
package com.api.util.testframework;
22

3-
import org.slf4j.Logger;
4-
import org.slf4j.LoggerFactory;
3+
//import org.slf4j.Logger;
4+
//import org.slf4j.LoggerFactory;
5+
import org.apache.logging.log4j.Logger;
6+
import org.apache.logging.log4j.LogManager;
57

68
import com.api.util.ApiSecurity.ApiList;
79
import com.api.util.ApiSecurity.ApiUtilException;
@@ -17,7 +19,7 @@
1719

1820
public class RuntimeTestUtility {
1921

20-
private static final Logger log = LoggerFactory.getLogger(RuntimeTestUtility.class);
22+
private static final Logger log = LogManager.getLogger(RuntimeTestUtility.class);
2123
private static ApiList apiList;
2224

2325
public static String getExpectedResultMap(ExpectedResult expectedResult) throws ApiUtilException {

0 commit comments

Comments
 (0)