[Bug] Wallet / Master Backpack radial menu entries and keybinds do nothing in the Craft 2 Exile Modpack

[RageMC]

Current Behaviour

I am using the Craft 2 Exile Modpack and i try to change the Radial Menu to open the Wallet or the Master Backpack when its equipped but it doesnt do anything. Do you think there is a way to fix this. They also do not work if i try to bind them to a key not using the radial menu

Expected Behaviour

When the Wallet or Master Backpack is equipped and I select its option from the radial menu, the corresponding inventory GUI should open.
When I bind Open Wallet or Open Master Backpack to a regular key and press that key in game, it should also open the correct inventory, as long as the item is equipped.

Screenshots

Reproduction Steps

Steps I’m taking:

1.Equip the Wallet or Master Backpack.

2.Open the radial menu.

3.Assign one of the slots to “Open Wallet” / “Open Master Backpack”

4.Activate that radial menu slot in game.

What happens:

Nothing opens when I select the Wallet or Master Backpack entry from the radial menu.

If I instead bind Open Wallet or Open Master Backpack directly to a key in the controls menu (not using the radial menu), pressing that key also does nothing.

I tried binding with the regular Backpack with both regular binding and radial menu and it works. I'm just listing these because they are active items i want to bind and use and others could or might not work but i haven't tested them.

There are no obvious error messages in chat or on screen.

Logs

Mod Version

2.1.8+1.20.1

Controller

Flydigi Apex 4 Controller

Bluetooth

• Yes

Operating System

Windows

ARM

• Yes

Additional Information

No response

Just to make sure...

• I have made sure I am using the latest version of Controlify for the latest version of Minecraft.
• I have made sure there are no other issues describing the same problem on the issue tracker.

[EchoEllet]

Thank you for the detailed bug report!
I will take a look soon.

[RageMC]

Thank you for the detailed bug report! I will take a look whenever I can.

Thanks for looking into this, i just happened to want to try to see if i can start using Controller for this mod pack and you just recently made this version for forge which is incredible. I'm just lucky to be able to have this even if its not possible for you to be able to fix it

[EchoEllet]

Nothing opens when I select the Wallet or Master Backpack entry from the radial menu.

If I instead bind Open Wallet or Open Master Backpack directly to a key in the controls menu (not using the radial menu), pressing that key also does nothing.

This is likely because the mod you're using does not handle the input in the vanilla standard supported way; these mods should not use InputEvents provided by Forge/NeoForge.

In fact, even NeoForge, Forge suggest not to use it in their doc sites:

• https://docs.neoforged.net/docs/misc/keymappings/#within-the-game
• https://docs.minecraftforge.net/en/latest/misc/keymappings/#within-the-game

Handling the input in the client tick event is the recommended way, and it's the only valid way in vanilla Minecraft or Fabric.

This isn't a Controlify or Controlify Forgified issue. There was a GitHub pull request to the original Controlify project that adds support for NeoForge's InputEvent, but I suggested not to use it for the following reasons.

Long story short

The InputEvents are not meant for handling the in-game input, it's a GLFW library detail and fired in MouseHandler and KeyboardHandler.
Any mod that uses them should be patched and refactor the current approach, as I did with Sword Soaring mod PR. But sometimes it's not straightforward.

There is probably not much I can do here. The mods should be patched to follow the Minecraft vanilla method of handling the input internally, and that is KeyMapping#consume inside a client-tick event, so Controlify key emulation can work, as it mixin on KeyMapping.

If you have any questions, let me know.

[RageMC]

Nothing opens when I select the Wallet or Master Backpack entry from the radial menu.
If I instead bind Open Wallet or Open Master Backpack directly to a key in the controls menu (not using the radial menu), pressing that key also does nothing.

This is likely because the mod you're using does not handle the input in the vanilla standard supported way; these mods should not use InputEvents provided by Forge/NeoForge.

In fact, even NeoForge, Forge suggest not to use it in their doc sites:

• https://docs.neoforged.net/docs/misc/keymappings/#within-the-game
• https://docs.minecraftforge.net/en/latest/misc/keymappings/#within-the-game

Handling the input in the client tick event is the recommended way, and it's the only valid way in vanilla Minecraft or [Fabric](https://wiki.fabricmc.net/tutorial:keybinds).

This isn't a Controlify or Controlify Forgified issue. There was a GitHub pull request to the original Controlify project that adds support for NeoForge's InputEvent, but I suggested not to use it for the following reasons.

Long story short

The InputEvents are not meant for handling the in-game input, it's a GLFW library detail and fired in MouseHandler and KeyboardHandler. Any mod that uses them should be patched and refactor the current approach, as I did with Sword Soaring mod PR. But sometimes it's not straightforward.

There is probably not much I can do here. The mods should be patched to follow the Minecraft vanilla method of handling the input internally, and that is KeyMapping#consume inside a client-tick event, so Controlify key emulation can work, as it mixin on KeyMapping.

If you have any questions, let me know.

Thanks for looking into it, I kinda understand what the issue is now. I think the best way it would be possible to fix this issue on my end would be to either figure out a way for the radial menu to input the default keyboard binds to the keys or use the M1-M4 buttons on my controller to click the keyboard combinations of the wallet or master backpack. I could do the latter with a third party app. Do you know if there is a way to configure the radial menu to click keyboard keys instead actual items or is it not possible. I’m assuming that it’s not because that might be the reason why the items are not working in the first place because of the handlers not being recognized.

[EchoEllet]

I think the best way

I think the best way to address this is to file issues with the mod authors in their GitHub repositories.

For example, with Irons' Spells and Spellbooks mod, I sent an issue report with the details (without making any assumptions about Controlify) and then sent them a PR iron431/irons-spells-n-spellbooks#989.

irons_spells_controlify.mp4

This is an efficient way of addressing it, though it requires more effort, explaining the issue and solution with alternatives, and will take time, but it's a good investment for a better long-term experience.

This could have been easily avoided if the InputEvents APIs by MinecraftForge were documented more straightforwardly.

[RageMC]

I think the best way

I think the best way to address this is to file issues with the mod authors in their GitHub repositories.

For example, with Irons' Spells and Spellbooks mod, I sent an issue report with the details (without making any assumptions about Controlify) and then sent them a PR iron431/irons-spells-n-spellbooks#989.
irons_spells_controlify.mp4

This is an efficient way of addressing it, though it requires more effort, explaining the issue and solution with alternatives, and will take time, but it's a good investment for a better long-term experience.

This could have been easily avoided if the InputEvents APIs by MinecraftForge were documented more straightforwardly.

Thanks for the explanation, i will keep that in mind

[EchoEllet]

I’m assuming that it’s not because that might be the reason why the items are not working in the first place because of the handlers not being recognized.

That's correct. This is only an issue with some NeoForge / Forge mods due to using non-vanilla APIs that are not standard and are MinecraftForge specific.

These MinecraftForge events are not meant for handling in-game input, so they shouldn't be called InputEvent in the first place.

I hope NeoForge can correct this common confusion at some point.