From 3a488908d28d0703650f7bb73b7d0ad0d7b13ab9 Mon Sep 17 00:00:00 2001 From: Michael Malone Date: Wed, 27 Apr 2016 17:06:16 -0700 Subject: [PATCH] improved pattern null check modified short circuit on 'pattern' parameter to use a truthy check rather than explicitly checking against undefined. This will stop the filter from processing when the pattern is null or empty in addition to undefined. --- src/angular-ui-tree-filter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/angular-ui-tree-filter.js b/src/angular-ui-tree-filter.js index 397ae98..0e27ea3 100755 --- a/src/angular-ui-tree-filter.js +++ b/src/angular-ui-tree-filter.js @@ -96,7 +96,7 @@ */ return function (item, pattern, addresses) { addresses = addresses || uiTreeFilterSettings.addresses; - return pattern === undefined || addresses.reduce(function (foundSoFar, fieldName) { + return !pattern || addresses.reduce(function (foundSoFar, fieldName) { return foundSoFar || testForField(item, pattern, fieldName); }, false); };