Optimization: Use BitFaster.Caching FastConcurrentLru for QueryCache

Author: SergeiPavlov

Orm/Xtensive.Orm/Orm/Domain.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2007-2020 Xtensive LLC.
+// Copyright (C) 2007-2021 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
@@ -9,6 +9,7 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
+using BitFaster.Caching.Lru;
 using JetBrains.Annotations;
 using Xtensive.Caching;
 using Xtensive.Collections;
@@ -121,7 +122,7 @@ public static Domain Demand()
 
     internal ConcurrentDictionary<TypeInfo, ReadOnlyList<PrefetchFieldDescriptor>> PrefetchFieldDescriptorCache { get; private set; }
 
-    internal ICache<object, Pair<object, TranslatedQuery>> QueryCache { get; private set; }
+    internal FastConcurrentLru<object, ParameterizedQuery> QueryCache { get; private set; }
 
     internal ICache<Key, Key> KeyCache { get; private set; }
 
@@ -422,7 +423,7 @@ internal Domain(DomainConfiguration configuration, object upgradeContextCookie,
       KeyGenerators = new KeyGeneratorRegistry();
       PrefetchFieldDescriptorCache = new ConcurrentDictionary<TypeInfo, ReadOnlyList<PrefetchFieldDescriptor>>();
       KeyCache = new LruCache<Key, Key>(Configuration.KeyCacheSize, k => k);
-      QueryCache = new LruCache<object, Pair<object, TranslatedQuery>>(Configuration.QueryCacheSize, k => k.First);
+      QueryCache = new FastConcurrentLru<object, ParameterizedQuery>(Configuration.QueryCacheSize);
       PrefetchActionMap = new Dictionary<TypeInfo, Action<SessionHandler, IEnumerable<Key>>>();
       Extensions = new ExtensionCollection();
       UpgradeContextCookie = upgradeContextCookie;

Orm/Xtensive.Orm/Orm/Internals/CompiledQueryRunner.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2012-2020 Xtensive LLC.
+// Copyright (C) 2012-2021 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
@@ -196,25 +196,11 @@ private void AllocateParameterAndReplacer()
       });
     }
 
-    private ParameterizedQuery GetCachedQuery()
-    {
-      var cache = domain.QueryCache;
-      lock (cache) {
-        return cache.TryGetItem(queryKey, true, out var item)
-          ? (ParameterizedQuery) item.Second
-          : null;
-      }
-    }
+    private ParameterizedQuery GetCachedQuery() =>
+      domain.QueryCache.TryGet(queryKey, out var query) ? query : null;
 
-    private void PutCachedQuery(ParameterizedQuery parameterizedQuery)
-    {
-      var cache = domain.QueryCache;
-      lock (cache) {
-        if (!cache.TryGetItem(queryKey, false, out _)) {
-          cache.Add(new Pair<object, TranslatedQuery>(queryKey, parameterizedQuery));
-        }
-      }
-    }
+    private void PutCachedQuery(ParameterizedQuery parameterizedQuery) =>
+      domain.QueryCache.AddOrUpdate(queryKey, parameterizedQuery);
 
     private ParameterContext CreateParameterContext(ParameterizedQuery query)
     {

Orm/Xtensive.Orm/Xtensive.Orm.csproj

@@ -41,6 +41,7 @@
   </ItemGroup>
   <ItemGroup Label="Packages">
     <PackageReference Include="System.Configuration.ConfigurationManager" Version="4.7.0" />
+    <PackageReference Include="BitFaster.Caching" Version="1.0.3" />
   </ItemGroup>
   <ItemGroup Label="T4GeneratorsUpdaters">
     <None Update="Arithmetic\Internal\PrimitiveArithmetics.tt">