Merge pull request #420 from DataObjects-NET/7.1-pgsql-nulls-order-in-indexes

alex-kulakov · web-flow · commit c2edc24c8250 · 2025-01-24T14:43:38.000+05:00
Postgresql: Declare the same setting for nulls in indexes as in order by statement
diff --git a/ChangeLog/7.1.4_dev.txt b/ChangeLog/7.1.4_dev.txt
@@ -1,2 +1,3 @@
 [main] Addressed IndexOutOfRangeException on translation of certain queries with aggregates
-[main] Notification to BuildLog when a hierarchy changes KeyGeneratorKind value to None
+[main] Notification to BuildLog when a hierarchy changes KeyGeneratorKind value to None
+[postgresql] Added explicit nulls setting for both column order directions to improve OrderBy/OrderByDescending performance
diff --git a/Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v9_0/Translator.cs b/Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v9_0/Translator.cs
@@ -30,6 +30,9 @@ public override void Translate(SqlCompilerContext context, object literalValue)
       }
     }
 
+    public override void TranslateSortOrder(IOutput output, bool ascending) =>
+      output.Append(ascending ? "ASC NULLS FIRST" : "DESC NULLS LAST");
+
     // Constructors
 
     public Translator(SqlDriver driver)

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,9 @@ public override void Translate(SqlCompilerContext context, object literalValue)`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`
	`33`	`+ public override void TranslateSortOrder(IOutput output, bool ascending) =>`
	`34`	`+ output.Append(ascending ? "ASC NULLS FIRST" : "DESC NULLS LAST");`
	`35`	`+`
`33`	`36`	`// Constructors`
`34`	`37`
`35`	`38`	`public Translator(SqlDriver driver)`