Skip to content

Commit 34fcbc9

Browse files
committed
Use StringComparison,Ordinal for string comparisons
1 parent ccc984a commit 34fcbc9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Extensions/Xtensive.Orm.BulkOperations/Internals/QueryOperation.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
33
using System.Linq;
44
using System.Linq.Expressions;
@@ -24,9 +24,9 @@ protected QueryOperation(QueryProvider queryProvider)
2424

2525
private static MethodInfo GetInMethod()
2626
{
27-
foreach (var method in typeof (QueryableExtensions).GetMethods().Where(a=>a.Name == "In")) {
27+
foreach (var method in typeof (QueryableExtensions).GetMethods().Where(a => string.Equals(a.Name, "In", StringComparison.Ordinal))) {
2828
var parameters = method.GetParameters();
29-
if (parameters.Length == 3 && parameters[2].ParameterType.Name == "IEnumerable`1")
29+
if (parameters.Length == 3 && string.Equals(parameters[2].ParameterType.Name, "IEnumerable`1", StringComparison.Ordinal))
3030
return method;
3131
}
3232
return null;
@@ -39,7 +39,7 @@ protected override int ExecuteInternal()
3939
var methodInfo = ex.Method;
4040
//rewrite localCollection.Contains(entity.SomeField) -> entity.SomeField.In(localCollection)
4141
if (methodInfo.DeclaringType == typeof(Enumerable) &&
42-
methodInfo.Name == "Contains" &&
42+
string.Equals(methodInfo.Name, "Contains", StringComparison.OrdinalIgnoreCase) &&
4343
ex.Arguments.Count == 2) {
4444
var localCollection = ex.Arguments[0];//IEnumerable<T>
4545
var valueToCheck = ex.Arguments[1];
@@ -49,7 +49,7 @@ protected override int ExecuteInternal()
4949
}
5050

5151
if (methodInfo.DeclaringType == typeof(QueryableExtensions) &&
52-
methodInfo.Name == "In" &&
52+
string.Equals(methodInfo.Name, "In", StringComparison.Ordinal) &&
5353
ex.Arguments.Count > 1) {
5454
if (ex.Arguments[1].Type == typeof(IncludeAlgorithm)) {
5555
var algorithm = (IncludeAlgorithm) ex.Arguments[1].Invoke();

0 commit comments

Comments
 (0)