fix: resolve typecheck issues

Author: brandonkachen

common/src/testing/fixtures/agent-runtime.ts

@@ -133,17 +133,17 @@ export const TEST_AGENT_RUNTIME_IMPL = Object.freeze<
  * Matches the shape of @codebuff/common/analytics.
  */
 type AnalyticsModule = {
-  initAnalytics: (...args: unknown[]) => void
-  trackEvent: (...args: unknown[]) => void
-  flushAnalytics?: (...args: unknown[]) => Promise<void>
+  initAnalytics: (...args: any[]) => void
+  trackEvent: (...args: any[]) => void
+  flushAnalytics?: (...args: any[]) => Promise<void>
 }
 
 /**
  * Type for the bigquery module to be mocked.
  * Matches the shape of @codebuff/bigquery.
  */
 type BigQueryModule = {
-  insertTrace: (...args: unknown[]) => Promise<boolean>
+  insertTrace: (...args: any[]) => Promise<boolean>
 }
 
 /**

packages/internal/src/utils/__tests__/version-utils.test.ts

@@ -7,6 +7,8 @@ import {
 
 import * as versionUtils from '../version-utils'
 
+import type { CodebuffPgDatabase } from '../../db/types'
+
 const {
   versionOne,
   parseVersion,
@@ -127,7 +129,7 @@ describe('version-utils', () => {
 
   describe('getLatestAgentVersion', () => {
     it('should return version 0.0.0 when no agent exists', async () => {
-      const mockDb = createVersionQueryDbMock([])
+      const mockDb = createVersionQueryDbMock([]) as unknown as CodebuffPgDatabase
 
       const result = await getLatestAgentVersion({
         agentId: 'test-agent',
@@ -138,7 +140,9 @@ describe('version-utils', () => {
     })
 
     it('should return latest version when agent exists', async () => {
-      const mockDb = createVersionQueryDbMock([{ major: 1, minor: 2, patch: 3 }])
+      const mockDb = createVersionQueryDbMock([
+        { major: 1, minor: 2, patch: 3 },
+      ]) as unknown as CodebuffPgDatabase
 
       const result = await getLatestAgentVersion({
         agentId: 'test-agent',
@@ -149,7 +153,9 @@ describe('version-utils', () => {
     })
 
     it('should handle null values in database response', async () => {
-      const mockDb = createVersionQueryDbMock([{ major: null, minor: null, patch: null }])
+      const mockDb = createVersionQueryDbMock([
+        { major: null, minor: null, patch: null },
+      ]) as unknown as CodebuffPgDatabase
 
       const result = await getLatestAgentVersion({
         agentId: 'test-agent',
@@ -162,7 +168,9 @@ describe('version-utils', () => {
 
   describe('determineNextVersion', () => {
     it('should increment patch of latest version when no version provided', async () => {
-      const mockDb = createVersionQueryDbMock([{ major: 1, minor: 2, patch: 3 }])
+      const mockDb = createVersionQueryDbMock([
+        { major: 1, minor: 2, patch: 3 },
+      ]) as unknown as CodebuffPgDatabase
 
       const result = await determineNextVersion({
         agentId: 'test-agent',
@@ -173,7 +181,7 @@ describe('version-utils', () => {
     })
 
     it('should use provided version when higher than latest', async () => {
-      const mockDb = createVersionQueryDbMock([])
+      const mockDb = createVersionQueryDbMock([]) as unknown as CodebuffPgDatabase
 
       const result = await determineNextVersion({
         agentId: 'test-agent',
@@ -185,7 +193,9 @@ describe('version-utils', () => {
     })
 
     it('should throw error when provided version is not greater than latest', async () => {
-      const mockDb = createVersionQueryDbMock([{ major: 2, minor: 0, patch: 0 }])
+      const mockDb = createVersionQueryDbMock([
+        { major: 2, minor: 0, patch: 0 },
+      ]) as unknown as CodebuffPgDatabase
 
       await expect(
         determineNextVersion({
@@ -200,7 +210,9 @@ describe('version-utils', () => {
     })
 
     it('should throw error when provided version equals latest', async () => {
-      const mockDb = createVersionQueryDbMock([{ major: 1, minor: 5, patch: 0 }])
+      const mockDb = createVersionQueryDbMock([
+        { major: 1, minor: 5, patch: 0 },
+      ]) as unknown as CodebuffPgDatabase
 
       await expect(
         determineNextVersion({
@@ -215,7 +227,7 @@ describe('version-utils', () => {
     })
 
     it('should throw error for invalid provided version', async () => {
-      const mockDb = createVersionQueryDbMock([])
+      const mockDb = createVersionQueryDbMock([]) as unknown as CodebuffPgDatabase
 
       await expect(
         determineNextVersion({
@@ -232,7 +244,9 @@ describe('version-utils', () => {
 
   describe('versionExists', () => {
     it('should return true when version exists', async () => {
-      const mockDb = createExistsQueryDbMock([{ id: 'test-agent' }])
+      const mockDb = createExistsQueryDbMock([
+        { id: 'test-agent' },
+      ]) as unknown as CodebuffPgDatabase
 
       const result = await versionExists({
         agentId: 'test-agent',
@@ -244,7 +258,7 @@ describe('version-utils', () => {
     })
 
     it('should return false when version does not exist', async () => {
-      const mockDb = createExistsQueryDbMock([])
+      const mockDb = createExistsQueryDbMock([]) as unknown as CodebuffPgDatabase
 
       const result = await versionExists({
         agentId: 'test-agent',

sdk/src/__tests__/code-search.test.ts

@@ -1,21 +1,30 @@
 import { EventEmitter } from 'events'
+import { PassThrough } from 'stream'
 
 import { describe, expect, it, beforeEach, afterEach, spyOn } from 'bun:test'
 
 import { codeSearchWithSpawn, type SpawnFn } from '../tools/code-search'
 
-import type { ChildProcess } from 'child_process'
+import type { ChildProcessByStdio } from 'child_process'
+import type { Readable } from 'stream'
 
 // Helper to create a mock child process with proper ChildProcess shape
-function createMockChildProcess(): ChildProcess {
-  const proc = new EventEmitter() as ChildProcess
-  const stdout = new EventEmitter()
-  const stderr = new EventEmitter()
+function createMockChildProcess(): ChildProcessByStdio<null, Readable, Readable> {
+  const proc = new EventEmitter() as unknown as ChildProcessByStdio<
+    null,
+    Readable,
+    Readable
+  >
+  const stdout: Readable = new PassThrough()
+  const stderr: Readable = new PassThrough()
 
   Object.defineProperty(proc, 'stdout', { value: stdout, writable: false })
   Object.defineProperty(proc, 'stderr', { value: stderr, writable: false })
   Object.defineProperty(proc, 'stdin', { value: null, writable: false })
-  Object.defineProperty(proc, 'stdio', { value: [null, stdout, stderr], writable: false })
+  Object.defineProperty(proc, 'stdio', {
+    value: [null, stdout, stderr, undefined, undefined],
+    writable: false,
+  })
   Object.defineProperty(proc, 'pid', { value: 12345, writable: false })
   Object.defineProperty(proc, 'killed', { value: false, writable: true })
   Object.defineProperty(proc, 'connected', { value: false, writable: false })
@@ -29,7 +38,7 @@ function createMockChildProcess(): ChildProcess {
 
 /** Creates a typed mock spawn function that captures calls and returns controlled processes */
 function createMockSpawn() {
-  let currentProcess: ChildProcess = createMockChildProcess()
+  let currentProcess = createMockChildProcess()
   const calls: Array<{ command: string; args: string[]; options: any }> = []
 
   const spawn: SpawnFn = (command, args, options) => {

sdk/src/tools/code-search.ts

@@ -5,7 +5,14 @@ import * as path from 'path'
 import { formatCodeSearchOutput } from '../../../common/src/util/format-code-search'
 import { getBundledRgPath } from '../native/ripgrep'
 
+import type {
+  ChildProcessByStdio,
+  SpawnOptionsWithStdioTuple,
+  StdioNull,
+  StdioPipe,
+} from 'child_process'
 import type { CodebuffToolOutput } from '../../../common/src/tools/list'
+import type { Readable } from 'stream'
 
 // Hidden directories to include in code search by default.
 // These are searched in addition to '.' to ensure important config/workflow files are discoverable.
@@ -18,7 +25,11 @@ const INCLUDED_HIDDEN_DIRS = [
   '.husky', // Git hooks
 ]
 
-export type SpawnFn = typeof nodeSpawn
+export type SpawnFn = (
+  command: string,
+  args: readonly string[],
+  options: SpawnOptionsWithStdioTuple<StdioNull, StdioPipe, StdioPipe>,
+) => ChildProcessByStdio<null, Readable, Readable>
 
 export function codeSearchWithSpawn(
   spawn: SpawnFn,