[feature] Remove warnings #3
Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
General cleanup of warnings
Describe the solution you'd like
A clear and concise description of what you want to happen.
I want 0 warnings to happen.
Such that enabling warnings as errors (/Wx on msvc) would produce a successful build.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Other alternatives are ignoring the warnings, and disabling warnings.
However warnings are often good indicators of a potential problem or mistake in code, and also msvc as well as gnu (afaik) allow you deal with other less desirable warnings.
In some cases I have already used #pragma warning(disable) for warnings such as inheritance via dominance (which was intentional)
Additional context
This is not necessarily a one and done issue, however at some point in time, cpp-engine should have 0 errors with a complete fresh build.