Skip to content

Commit 2e990ee

Browse files
dmccrystals0h3yl
authored andcommitted
refactor: drop default value for language_code
GitOrigin-RevId: b7b6deec85b270ad0a6d8f3e3697097f29f24782
1 parent b98b963 commit 2e990ee

File tree

2 files changed

+27
-5
lines changed

2 files changed

+27
-5
lines changed

assemblyai/types.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ class SummarizationType(str, Enum):
313313

314314

315315
class RawTranscriptionConfig(BaseModel):
316-
language_code: LanguageCode = LanguageCode.en_us
316+
language_code: Optional[LanguageCode]
317317
"""
318318
The language of your audio file. Possible values are found in Supported Languages.
319319
@@ -423,7 +423,7 @@ class Config:
423423
class TranscriptionConfig:
424424
def __init__(
425425
self,
426-
language_code: LanguageCode = LanguageCode.en_us,
426+
language_code: Optional[LanguageCode] = None,
427427
punctuate: Optional[bool] = None,
428428
format_text: Optional[bool] = None,
429429
dual_channel: Optional[bool] = None,
@@ -543,12 +543,12 @@ def raw(self) -> RawTranscriptionConfig:
543543
# region: Getters/Setters
544544

545545
@property
546-
def language_code(self) -> LanguageCode:
546+
def language_code(self) -> Optional[LanguageCode]:
547547
"The language code of the audio file."
548548
return self._raw_transcription_config.language_code
549549

550550
@language_code.setter
551-
def language_code(self, language_code: LanguageCode) -> None:
551+
def language_code(self, language_code: Optional[LanguageCode]) -> None:
552552
"Sets the language code of the audio file."
553553

554554
self._raw_transcription_config.language_code = language_code
@@ -1357,7 +1357,7 @@ class BaseTranscript(BaseModel):
13571357
Available transcription features
13581358
"""
13591359

1360-
language_code: LanguageCode = LanguageCode.en_us
1360+
language_code: Optional[LanguageCode]
13611361
"""
13621362
The language of your audio file. Possible values are found in Supported Languages.
13631363

tests/unit/test_transcriber.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import copy
2+
import json
23
import os
34
from unittest.mock import mock_open, patch
45

@@ -425,3 +426,24 @@ def test_transcribe_async_url_fails(httpx_mock: HTTPXMock):
425426

426427
# check whether we mocked everything
427428
assert len(httpx_mock.get_requests()) == 3
429+
430+
431+
def test_language_detection(httpx_mock: HTTPXMock):
432+
httpx_mock.add_response(
433+
url=f"{aai.settings.base_url}/transcript",
434+
status_code=httpx.codes.OK,
435+
method="POST",
436+
json={},
437+
)
438+
439+
aai.Transcriber().transcribe(
440+
"https://example.org/audio.wav",
441+
config=aai.TranscriptionConfig(
442+
language_code=None,
443+
language_detection=True,
444+
),
445+
)
446+
447+
request = json.loads(httpx_mock.get_requests()[0].content.decode())
448+
assert request["language_detection"] is True
449+
assert request.get("language_code") is None

0 commit comments

Comments
 (0)