Skip to content

Commit 7713289

Browse files
committed
fix: change to using HasFlag for checking existing compare results
1 parent d087475 commit 7713289

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/AngleSharp.Diffing/Strategies/AttributeStrategies/BooleanAttributeComparer.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ public CompareResult Compare(in AttributeComparison comparison, CompareResult cu
7070
? CompareStrict(comparison)
7171
: true;
7272

73-
return hasSameValue ?
74-
CompareResult.Same :
75-
CompareResult.FromDiff(new AttrDiff(comparison, AttrDiffKind.Value));
73+
return hasSameValue
74+
? CompareResult.Same
75+
: CompareResult.FromDiff(new AttrDiff(comparison, AttrDiffKind.Value));
7676
}
7777

7878
private static bool IsAttributeNamesEqual(in AttributeComparison comparison)

src/AngleSharp.Diffing/Strategies/ElementStrategies/ElementComparer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public CompareResult Compare(in Comparison comparison, CompareResult currentDeci
4141
? CompareResult.Same
4242
: CompareResult.FromDiff(new ElementDiff(comparison, ElementDiffKind.Name));
4343

44-
if (EnforceTagClosing && result == CompareResult.Same)
44+
if (EnforceTagClosing && result.Decision.HasFlag(CompareDecision.Same))
4545
{
4646
if (testElement.SourceReference is not HtmlTagToken testTag)
4747
throw new InvalidOperationException("No source reference attached to test element, cannot determine element tag closing style.");

src/AngleSharp.Diffing/Strategies/ElementStrategies/IgnoreAttributesElementComparer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public static class IgnoreAttributesElementComparer
1212
/// </summary>
1313
public static CompareResult Compare(in Comparison comparison, CompareResult currentDecision)
1414
{
15-
if (currentDecision == CompareResult.Skip || currentDecision == CompareResult.SkipAttributes || currentDecision == CompareResult.SkipChildrenAndAttributes)
15+
if (currentDecision.Decision.HasFlag(CompareDecision.Skip) || currentDecision.Decision.HasFlag(CompareDecision.SkipAttributes))
1616
return currentDecision;
1717

1818
if (!ControlHasTruthyIgnoreAttributesAttribute(comparison))

src/AngleSharp.Diffing/Strategies/ElementStrategies/IgnoreElementComparer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public static class IgnoreElementComparer
1212
/// </summary>
1313
public static CompareResult Compare(in Comparison comparison, CompareResult currentDecision)
1414
{
15-
if (currentDecision == CompareResult.Skip)
15+
if (currentDecision.Decision.HasFlag(CompareDecision.Skip))
1616
return currentDecision;
1717

1818
return ControlHasTruthyIgnoreAttribute(comparison)

0 commit comments

Comments
 (0)